DOM: listeners on target are now copied twice #16307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We changed event dispatch to have a "capturing" and "bubbling" phase. Each phase does AT_TARGET handling. Each phase also copies listeners. This means that listeners added during "capturing", now run during "bubbling", where they previously did not. See whatwg/dom#746 for additional context.
annevk
added a commit
to whatwg/dom
that referenced
this pull request
Apr 10, 2019
This fixes a regression from #686. Tests: various tests were failing because of this. web-platform-tests/wpt#16307 aligns the remaining failing test with the new model. Fixes #742.
hayatoito
approved these changes
Apr 10, 2019
annevk
added a commit
to whatwg/dom
that referenced
this pull request
Apr 15, 2019
This fixes a regression from #686. Tests: various tests were failing because of this. web-platform-tests/wpt#16307 aligns the remaining failing test with the new model. Fixes #742.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed event dispatch to have a "capturing" and "bubbling" phase. Each phase does AT_TARGET handling. Each phase also copies listeners. This means that listeners added during "capturing", now run during "bubbling", where they previously did not.
See whatwg/dom#746 for additional context.