[Gecko Bug 1655393] Add WPT for `InputEvent.getTargetRanges() #24866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no automated tests for `InputEvent.getTargetRanges()` because it is set only when `beforeinput` event, but it's defined as not dispatched by `document.execCommand`. However, we can synthesize `beforeinput` event with test driver. On the other hand, the definition in Input Events spec is not clear. Therefore, most of the tests won't be passed on any browsers for now. There are some spec issues which I filed: * w3c/input-events#112 * w3c/input-events#113 * w3c/input-events#114 These new test must be useful when browser vendors discuss the issues. Differential Revision: https://phabricator.services.mozilla.com/D85527 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1655393 gecko-commit: 12f21ad909371384939bb38d65cf1dbc797b5bf9 gecko-integration-branch: autoland gecko-reviewers: smaug
wpt-pr-bot
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no automated tests for
InputEvent.getTargetRanges()because itis set only when
beforeinputevent, but it's defined as not dispatched bydocument.execCommand.However, we can synthesize
beforeinputevent with test driver.On the other hand, the definition in Input Events spec is not clear.
Therefore, most of the tests won't be passed on any browsers for now.
There are some spec issues which I filed:
InputEvent.getTargetRanges()definition w3c/input-events#112getTargetRanges()ofinputw3c/input-events#113getTargetRanges()ofbeforeinputafter propagation w3c/input-events#114These new test must be useful when browser vendors discuss the issues.
Differential Revision: https://phabricator.services.mozilla.com/D85527
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1655393
gecko-commit: 12f21ad909371384939bb38d65cf1dbc797b5bf9
gecko-integration-branch: autoland
gecko-reviewers: smaug