Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blink: fix LayoutObject::OffsetFromContainerInternal #25941

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Oct 2, 2020

It should only call OffsetFromScrollableContainer() if the
supplied LayoutObject is a scroll container.

BUG=1134184
TEST=covered by clusterfuzz

Change-Id: I1109a8514590882246dfebe46b7340ac654829cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442895
Reviewed-by: Ian Kilpatrick <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#813272}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@frivoal
Copy link
Contributor

frivoal commented Oct 2, 2020

The lint error was caused by #16043 and has been fixed by #25944, please rebase to move past this problem.

It should only call OffsetFromScrollableContainer() if the
supplied LayoutObject is a scroll container.

BUG=1134184
TEST=covered by clusterfuzz

Change-Id: I1109a8514590882246dfebe46b7340ac654829cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442895
Reviewed-by: Ian Kilpatrick <[email protected]>
Commit-Queue: Scott Violet <[email protected]>
Cr-Commit-Position: refs/heads/master@{#813272}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 50be838 into master Oct 2, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2442895 branch October 2, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants