-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to disallow 3rd party origin subframe JS dialogs #27435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
49c16b7
to
c43088d
Compare
@web-platform-tests/wpt-core-team Re:wpt-chrome-dev-stability. Chrome is expected to fail this WPT since the feature is not still implemented in Chrome by default. But this is triggering the flakiness check due to it sometimes failing (due to an unexpected alert), and other times timing out (due to the alert remaining open presumably). |
@carlosjoan91 you can add |
Ack; I suspect this is actually showing a bug with how we handle unexpectedly open alerts (possibly in webdriver). I don't think a long timeout would help. We're happy to admin-merge this PR once the Chromium CL has landed. |
c43088d
to
39c34aa
Compare
Test: Covered by WPT, except for alert (which can't be tested in WPT). Bug: 1065085 Change-Id: I8a58be63014c7893ab864d3582516a9eddbf5e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645693 Commit-Queue: Carlos IL <[email protected]> Reviewed-by: Avi Drissman <[email protected]> Cr-Commit-Position: refs/heads/master@{#851920}
39c34aa
to
25d7afb
Compare
Thanks for merging! And yeah, having this in the current flaky between failing and timing out is not particularly terrible, since it will go back to reliably passing once the feature is enabled by default in Chromium. |
Test: Covered by WPT, except for alert (which can't be tested in WPT).
Bug: 1065085
Change-Id: I8a58be63014c7893ab864d3582516a9eddbf5e25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645693
Commit-Queue: Carlos IL <[email protected]>
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/heads/master@{#851920}