[wpt] Fix grid-item (no) aspect-ratio tests. #29567
Merged
+201
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 2, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3003564
branch
from
57fac4f to
e4aa377
Compare
Renaming scheme got lost, however basically: grid-item-no-aspect-ratio-stretch-4.html -> grid-item-aspect-ratio-stretch-1.html grid-item-no-aspect-ratio-stretch-5.html -> grid-item-aspect-ratio-stretch-2.html grid-item-no-aspect-ratio-stretch-6.html -> grid-item-aspect-ratio-stretch-3.html grid-item-no-aspect-ratio-stretch-7.html -> grid-item-aspect-ratio-stretch-4.html These tests all had a viewBox defining a valid aspect-ratio. Due to: w3c/csswg-drafts#6286 (comment) These tests *should* have an aspect-ratio, and when stretched in one dimension, should reflect to the other dimension (if unconstrained). See: w3c/csswg-drafts#5713 (comment) The below two tests basically just got renamed: grid-item-no-aspect-ratio-stretch-8.html -> grid-item-no-aspect-ratio-stretch-4.html grid-item-no-aspect-ratio-stretch-9.html -> grid-item-no-aspect-ratio-stretch-5.html grid-item-no-aspect-ratio-stretch-10.html -> grid-item-no-aspect-ratio-stretch-6.html But tests updated to correctly assert that the natural size would still be respected. To all these test-cases I also added "grid-template: 100% / 100%;" as there is further complexity when inside an auto row/column which is tested elsewhere. (Transferred minimum size for replaced elements with an aspect-ratio). Bug: 1114013 Change-Id: I062f67e291cc62fa63a53370595780dae16abf3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3003564 Reviewed-by: David Grogan <[email protected]> Reviewed-by: Kurt Catti-Schmidt <[email protected]> Commit-Queue: Ian Kilpatrick <[email protected]> Cr-Commit-Position: refs/heads/master@{#898351}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3003564
branch
from
e4aa377 to
d56d139
Compare
foolip
added a commit
to Ecosystem-Infra/wpt-results-analysis
that referenced
this pull request
Sep 7, 2021
These are all removed or renamed: - /css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-*.html in web-platform-tests/wpt#29567 - /css/css-sizing/aspect-ratio/grid-aspect-ratio-013.html in web-platform-tests/wpt#29577 - /css/css-transforms/3d-rendering-context-behavior.tentative.html in web-platform-tests/wpt#29424 - /css/css-transforms/preserve-3d-flat-grouping-properties-containing-block.tentative.html in web-platform-tests/wpt#29425 - /css/css-transforms/scrolalble-*-3d-transform-z.html in web-platform-tests/wpt#30126
stephenmcgruer
pushed a commit
to Ecosystem-Infra/wpt-results-analysis
that referenced
this pull request
Sep 8, 2021
These are all removed or renamed: - /css/css-grid/alignment/grid-item-no-aspect-ratio-stretch-*.html in web-platform-tests/wpt#29567 - /css/css-sizing/aspect-ratio/grid-aspect-ratio-013.html in web-platform-tests/wpt#29577 - /css/css-transforms/3d-rendering-context-behavior.tentative.html in web-platform-tests/wpt#29424 - /css/css-transforms/preserve-3d-flat-grouping-properties-containing-block.tentative.html in web-platform-tests/wpt#29425 - /css/css-transforms/scrolalble-*-3d-transform-z.html in web-platform-tests/wpt#30126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming scheme got lost, however basically:
grid-item-no-aspect-ratio-stretch-4.html -> grid-item-aspect-ratio-stretch-1.html
grid-item-no-aspect-ratio-stretch-5.html -> grid-item-aspect-ratio-stretch-2.html
grid-item-no-aspect-ratio-stretch-6.html -> grid-item-aspect-ratio-stretch-3.html
grid-item-no-aspect-ratio-stretch-7.html -> grid-item-aspect-ratio-stretch-4.html
These tests all had a viewBox defining a valid aspect-ratio. Due to:
w3c/csswg-drafts#6286 (comment)
These tests should have an aspect-ratio, and when stretched in one
dimension, should reflect to the other dimension (if unconstrained). See:
w3c/csswg-drafts#5713 (comment)
The below two tests basically just got renamed:
grid-item-no-aspect-ratio-stretch-8.html -> grid-item-no-aspect-ratio-stretch-4.html
grid-item-no-aspect-ratio-stretch-9.html -> grid-item-no-aspect-ratio-stretch-5.html
grid-item-no-aspect-ratio-stretch-10.html -> grid-item-no-aspect-ratio-stretch-6.html
But tests updated to correctly assert that the natural size would still
be respected.
To all these test-cases I also added "grid-template: 100% / 100%;" as
there is further complexity when inside an auto row/column which is
tested elsewhere.
(Transferred minimum size for replaced elements with an aspect-ratio).
Bug: 1114013
Change-Id: I062f67e291cc62fa63a53370595780dae16abf3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3003564
Reviewed-by: David Grogan <[email protected]>
Reviewed-by: Kurt Catti-Schmidt <[email protected]>
Commit-Queue: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/master@{#898351}