-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test that consumption & preload of CSP-blocked resources are both reported #33205
Conversation
const uid = new URLSearchParams(location.search).get('uid'); | ||
// const bc = new BroadcastChannel(uid); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems sketchy. Line that's commented out below as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, was not prepared to land this yet - wanted to see that we agree on the main PR. Will prepare this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Also correct spelling of a variable. Tests: web-platform-tests/wpt#33109 & web-platform-tests/wpt#33205. Closes whatwg/html#7686.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, modulo nit.
<!-- This image will cause a CSP violation, which will trigger an immediate report --> | ||
<script> | ||
const href = "/reporting/resources/fail.png"; | ||
const uid = new URLSearchParams(location.search).get('uid'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed then, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, removed
No description provided.