Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that consumption & preload of CSP-blocked resources are both reported #33205

Merged
merged 3 commits into from
Mar 17, 2022

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Mar 16, 2022

No description provided.

Comment on lines 7 to 8
const uid = new URLSearchParams(location.search).get('uid');
// const bc = new BroadcastChannel(uid);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems sketchy. Line that's commented out below as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, was not prepared to land this yet - wanted to see that we agree on the main PR. Will prepare this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

annevk pushed a commit to whatwg/fetch that referenced this pull request Mar 17, 2022
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, modulo nit.

<!-- This image will cause a CSP violation, which will trigger an immediate report -->
<script>
const href = "/reporting/resources/fail.png";
const uid = new URLSearchParams(location.search).get('uid');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed then, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants