Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add range tests for blob #34384
Add range tests for blob #34384
Changes from all commits
7fd647b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I suggest we add some more invalid cases here to cover more parts of the parser:
bytes=x
bytes 5-
5-
bytes=5-x
bytes=x-5
Other places we could add more coverage for is whitespace handling between the various tokens.
Let me know if you'd like some help. I can make some time to push a few tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RFC 7233 doesn't seem to indicate a position on whitespace. Is this specified somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does although in a convoluted way. See https://httpwg.org/specs/rfc7233.html#rfc.section.1.2 and https://httpwg.org/specs/rfc7233.html#collected.abnf for "normal" ABNF. It seems it allows whitespace in only a few places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems I was wrong here, but I think we should still test cases like:
bytes=5 - 10
bytes= - \t5
They should probably fail given the RFC, but it seems like implementations are already not following the RFC for whitespace after
bytes=
so who knows.Perhaps this is also a thing we can still tighten however.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on some recent tests WebKit and Blink do seem to allow range specifications with whitespace like this...