Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1775501] multipart boundary should be handled as mixed case #34788

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

moz-wptsync-bot
Copy link
Collaborator

Since w3c/FileAPI#43 is still open, it is unclear how body.type should work.
The current wpts expect some behavior which isn't in the specifications.
So, since the situation is very messy in the specifications, the patch is doing a
spot fix for boundary handling. It is ugly, but shouldn't change other behavior.

Differential Revision: https://phabricator.services.mozilla.com/D150018

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1775501
gecko-commit: 22a157de1bfa502e10ec05c9b17611f2eba47b0e
gecko-reviewers: kershaw

Since w3c/FileAPI#43 is still open, it is unclear how body.type should work.
The current wpts expect some behavior which isn't in the specifications.
So, since the situation is very messy in the specifications, the patch is doing a
spot fix for boundary handling. It is ugly, but shouldn't change other behavior.

Differential Revision: https://phabricator.services.mozilla.com/D150018

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1775501
gecko-commit: 22a157de1bfa502e10ec05c9b17611f2eba47b0e
gecko-reviewers: kershaw
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Firefox project.

@moz-wptsync-bot moz-wptsync-bot merged commit 35653f6 into master Jul 11, 2022
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1775501 branch July 11, 2022 19:58
@jimmywarting
Copy link
Contributor

  const r = new Response(new Blob([form_string]), {
    headers: [
      [
        "Content-Type",
        "multipart/form-data; boundary=Boundary_with_capital_letters",
      ],
    ],

I think there should also be a test case where it sets the blob type and the response set's the content-type out of the blob.type... like this:

const blob = new Blob([form_string], { type: "multipart/form-data; boundary=Boundary_with_capital_letters" })
new Response(blob)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants