Remove pop-up test for unscopable popup attr
#36545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 19, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3963911
branch
from
e70b408 to
92335f1
Compare
There was a previous web compat issue with event handler attributes calling functions called "popup()". As a result, we made the `popup` attribute unscopable, so this would not break the web. However, with the change of name to `popUp` for the IDL attribute, this compat issue likely doesn't exist, for the same reasons that this rename fixed the general compat issue [1]. This CL removes the test for unscopable. The [2] CL actually made the attribute scopable. [1] openui/open-ui#546 [2] https://chromium-review.googlesource.com/c/chromium/src/+/3954386 Bug: 1307772 Change-Id: I603e75338e1ccb925e6f145870fa6fecc68c61fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3963911 Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Mason Freed <[email protected]> Auto-Submit: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1062228}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3963911
branch
from
92335f1 to
f91346d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a previous web compat issue with event handler attributes
calling functions called "popup()". As a result, we made the
popupattribute unscopable, so this would not break the web. However,
with the change of name to
popUpfor the IDL attribute, thiscompat issue likely doesn't exist, for the same reasons that this
rename fixed the general compat issue [1].
This CL removes the test for unscopable. The [2] CL actually made
the attribute scopable.
[1] openui/open-ui#546
[2] https://chromium-review.googlesource.com/c/chromium/src/+/3954386
Bug: 1307772
Change-Id: I603e75338e1ccb925e6f145870fa6fecc68c61fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3963911
Reviewed-by: Joey Arhar <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1062228}