view-transitions: Clip snapshots to max texture size/viewport. #38946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 11, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4330193
branch
2 times, most recently
from
d047e78 to
671f387
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4330193
branch
3 times, most recently
from
691420b to
134796a
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4330193
branch
5 times, most recently
from
275ef3f to
2cfa7f5
Compare
If an element's painting exceeds viewport bounds, clip it down to max texture size or twice the viewport bounds by painting the subset which is closest to the snapshot root. This involves the following 2 changes: 1) A new ClipNode is introduced to paint the desired subrect when rendering this element in paint, raster and compositing. All these stages should render only this subset. 2) The object-view-box on the replaced element is still set to the ink overflow rect. So at paint time, we adjust the replaced content rect to the actual subset that will be painted based on the clipping above. [email protected], [email protected], [email protected] Bug: 1409713 Change-Id: If81bc67ad6ffe49d68e4470a6717b704edafcd3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4330193 Reviewed-by: Xianzhu Wang <[email protected]> Commit-Queue: Khushal Sagar <[email protected]> Reviewed-by: Philip Rogers <[email protected]> Auto-Submit: Khushal Sagar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1121126}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4330193
branch
from
2cfa7f5 to
e79a3db
Compare
marcoscaceres
pushed a commit
that referenced
this pull request
Mar 28, 2023
If an element's painting exceeds viewport bounds, clip it down to max texture size or twice the viewport bounds by painting the subset which is closest to the snapshot root. This involves the following 2 changes: 1) A new ClipNode is introduced to paint the desired subrect when rendering this element in paint, raster and compositing. All these stages should render only this subset. 2) The object-view-box on the replaced element is still set to the ink overflow rect. So at paint time, we adjust the replaced content rect to the actual subset that will be painted based on the clipping above. [email protected], [email protected], [email protected] Bug: 1409713 Change-Id: If81bc67ad6ffe49d68e4470a6717b704edafcd3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4330193 Reviewed-by: Xianzhu Wang <[email protected]> Commit-Queue: Khushal Sagar <[email protected]> Reviewed-by: Philip Rogers <[email protected]> Auto-Submit: Khushal Sagar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1121126} Co-authored-by: Khushal Sagar <[email protected]>
cookiecrook
pushed a commit
to cookiecrook/wpt
that referenced
this pull request
Mar 29, 2023
…latform-tests#38946) If an element's painting exceeds viewport bounds, clip it down to max texture size or twice the viewport bounds by painting the subset which is closest to the snapshot root. This involves the following 2 changes: 1) A new ClipNode is introduced to paint the desired subrect when rendering this element in paint, raster and compositing. All these stages should render only this subset. 2) The object-view-box on the replaced element is still set to the ink overflow rect. So at paint time, we adjust the replaced content rect to the actual subset that will be painted based on the clipping above. [email protected], [email protected], [email protected] Bug: 1409713 Change-Id: If81bc67ad6ffe49d68e4470a6717b704edafcd3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4330193 Reviewed-by: Xianzhu Wang <[email protected]> Commit-Queue: Khushal Sagar <[email protected]> Reviewed-by: Philip Rogers <[email protected]> Auto-Submit: Khushal Sagar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1121126} Co-authored-by: Khushal Sagar <[email protected]>
cookiecrook
pushed a commit
to cookiecrook/wpt
that referenced
this pull request
Apr 8, 2023
…latform-tests#38946) If an element's painting exceeds viewport bounds, clip it down to max texture size or twice the viewport bounds by painting the subset which is closest to the snapshot root. This involves the following 2 changes: 1) A new ClipNode is introduced to paint the desired subrect when rendering this element in paint, raster and compositing. All these stages should render only this subset. 2) The object-view-box on the replaced element is still set to the ink overflow rect. So at paint time, we adjust the replaced content rect to the actual subset that will be painted based on the clipping above. [email protected], [email protected], [email protected] Bug: 1409713 Change-Id: If81bc67ad6ffe49d68e4470a6717b704edafcd3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4330193 Reviewed-by: Xianzhu Wang <[email protected]> Commit-Queue: Khushal Sagar <[email protected]> Reviewed-by: Philip Rogers <[email protected]> Auto-Submit: Khushal Sagar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1121126} Co-authored-by: Khushal Sagar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an element's painting exceeds viewport bounds, clip it down to max
texture size or twice the viewport bounds by painting the subset which
is closest to the snapshot root.
This involves the following 2 changes:
A new ClipNode is introduced to paint the desired subrect when
rendering this element in paint, raster and compositing. All these
stages should render only this subset.
The object-view-box on the replaced element is still set to the
ink overflow rect. So at paint time, we adjust the replaced content
rect to the actual subset that will be painted based on the clipping
above.
R=[email protected], [email protected], [email protected]
Bug: 1409713
Change-Id: If81bc67ad6ffe49d68e4470a6717b704edafcd3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4330193
Reviewed-by: Xianzhu Wang <[email protected]>
Commit-Queue: Khushal Sagar <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Auto-Submit: Khushal Sagar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1121126}