-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse helpers; stop running iframe tests concurrently; set test context #39275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
e3bb674
to
d9e4de8
Compare
This CL also adds some missing return statements that cause the test to drop some promises instead of awaiting them properly. Bug: 1427180 Change-Id: I7e7411e871c13da78c30bf1308a2ada11f577553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4382128 Reviewed-by: Matt Reichhoff <[email protected]> Commit-Queue: Chris Fredrickson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1123812}
d9e4de8
to
000367a
Compare
Some affected tests had inconsistent (flaky) results: Unstable results
These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag |
Looks like this is fixed in https://chromium-review.googlesource.com/c/chromium/src/+/4381927 @jcscottiii @KyleJu Can you help admin merge? thanks! |
@WeizhongX thanks for tracking that down. Merged! |
…xt (web-platform-tests#39275) This CL also adds some missing return statements that cause the test to drop some promises instead of awaiting them properly. Bug: 1427180 Change-Id: I7e7411e871c13da78c30bf1308a2ada11f577553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4382128 Reviewed-by: Matt Reichhoff <[email protected]> Commit-Queue: Chris Fredrickson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1123812} Co-authored-by: Chris Fredrickson <[email protected]>
This CL also adds some missing return statements that cause the test
to drop some promises instead of awaiting them properly.
Bug: 1427180
Change-Id: I7e7411e871c13da78c30bf1308a2ada11f577553
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4382128
Reviewed-by: Matt Reichhoff <[email protected]>
Commit-Queue: Chris Fredrickson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1123812}