Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse helpers; stop running iframe tests concurrently; set test context #39275

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 29, 2023

This CL also adds some missing return statements that cause the test
to drop some promises instead of awaiting them properly.

Bug: 1427180
Change-Id: I7e7411e871c13da78c30bf1308a2ada11f577553
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4382128
Reviewed-by: Matt Reichhoff <[email protected]>
Commit-Queue: Chris Fredrickson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1123812}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

This CL also adds some missing return statements that cause the test
to drop some promises instead of awaiting them properly.

Bug: 1427180
Change-Id: I7e7411e871c13da78c30bf1308a2ada11f577553
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4382128
Reviewed-by: Matt Reichhoff <[email protected]>
Commit-Queue: Chris Fredrickson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1123812}
@WeizhongX
Copy link
Contributor

python3 ./wpt run --channel=nightly --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full --binary=/home/test/build/firefox/firefox firefox

Some affected tests had inconsistent (flaky) results:

Unstable results

Test Subtest Results Messages
/top-level-storage-access-api/tentative/requestStorageAccessFor-insecure.sub.window.html [top-level-context] document.requestStorageAccessFor() should be rejected when called in an insecure context FAIL: 7/10, NOTRUN: 3/10 promise_test: Unhandled rejection with value: object "TypeError: document.requestStorageAccessFor is not a function"

These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag @web-platform-tests/wpt-core-team in a comment for help.

@WeizhongX
Copy link
Contributor

Looks like this is fixed in https://chromium-review.googlesource.com/c/chromium/src/+/4381927

@jcscottiii @KyleJu Can you help admin merge? thanks!

@jcscottiii jcscottiii merged commit a5dc2e5 into master Mar 31, 2023
@jcscottiii jcscottiii deleted the chromium-export-cl-4382128 branch March 31, 2023 18:34
@jcscottiii
Copy link
Contributor

@WeizhongX thanks for tracking that down. Merged!

cookiecrook pushed a commit to cookiecrook/wpt that referenced this pull request Apr 8, 2023
…xt (web-platform-tests#39275)

This CL also adds some missing return statements that cause the test
to drop some promises instead of awaiting them properly.

Bug: 1427180
Change-Id: I7e7411e871c13da78c30bf1308a2ada11f577553
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4382128
Reviewed-by: Matt Reichhoff <[email protected]>
Commit-Queue: Chris Fredrickson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1123812}

Co-authored-by: Chris Fredrickson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants