[popover] Reset state in some subtests #39304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some subtests failure to close the popover (due to some exception/assert failure) would result in the next subtest to start in an environment that is not reset to a clean state, so add some cleanup handlers.
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham and
zqzhang
annevk
approved these changes
Mar 31, 2023
|
(I worry a tiny bit this will turn into a conflict with |
cookiecrook
pushed a commit
to cookiecrook/wpt
that referenced
this pull request
Apr 8, 2023
For some subtests failure to close the popover (due to some exception/assert failure) would result in the next subtest to start in an environment that is not reset to a clean state, so add some cleanup handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some subtests failure to close the popover (due to some exception/assert failure) would result in the next subtest to start in an environment that is not reset to a clean state, so add some cleanup handlers.