Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for :open/:closed support #39361

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

rwlbuis
Copy link
Contributor

@rwlbuis rwlbuis commented Apr 4, 2023

The test popover-attribute-basic.html assumes :open/:closed pseudo-classes are supported, but this is not a given, test for that first to avoid errors/exceptions.

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big fan of conditional testing, but I guess this can work for now. Please add a FIXME comment that once :open/:closed are defined in HTML we remove the additional conditionals.

The test popover-attribute-basic.html assumes :open/:closed
pseudo-classes are supported, but this is not a given, test
for that first to avoid errors/exceptions.
@rwlbuis rwlbuis force-pushed the popover-open-closed-pseudo-class-usage branch from cc17a2e to b8636a0 Compare April 4, 2023 13:43
@rwlbuis rwlbuis merged commit c751476 into master Apr 4, 2023
@rwlbuis rwlbuis deleted the popover-open-closed-pseudo-class-usage branch April 4, 2023 14:31
cookiecrook pushed a commit to cookiecrook/wpt that referenced this pull request Apr 8, 2023
The test popover-attribute-basic.html assumes :open/:closed
pseudo-classes are supported, but this is not a given, test
for that first to avoid errors/exceptions.
moz-wptsync-bot added a commit that referenced this pull request Apr 13, 2023
Implements #39361 too, in
order to avoid failing CI tests.

Depends on D175223

Differential Revision: https://phabricator.services.mozilla.com/D175224

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1825807
gecko-commit: 454a01f16f5b75d0f4f77ac84e772e6b09c6ba83
gecko-reviewers: emilio
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 13, 2023
Implements web-platform-tests/wpt#39361 too, in
order to avoid failing CI tests.

Depends on D175223

Differential Revision: https://phabricator.services.mozilla.com/D175224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants