[wpt-lint] Handle FileNotFoundError when git is not found
#39416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tools.lint.lint` is unimportable when `git` does not exist in the
`PATH`:
```
File "C:\b\s\w\ir\third_party\blink\tools\blinkpy\tool\commands\lint_wpt.py", line 16, in <module>
from tools.lint import lint as wptlint
File "C:\b\s\w\ir\third_party\wpt_tools\wpt\tools\lint\__init__.py", line 1, in <module>
from . import lint # noqa: F401
File "C:\b\s\w\ir\third_party\wpt_tools\wpt\tools\lint\lint.py", line 1135, in <module>
subprocess.check_output(["git", "--version"])
...
File "C:\b\s\w\ir\.task_template_vpython_cache\vpython\store\cpython-e6tenrlsesftvg6k08ajgkk7b4\contents\bin\Lib\subprocess.py", line 1311, in _execute_child
hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
FileNotFoundError: [WinError 2] The system cannot find the file specified
```
jonathan-j-lee
requested review from
WeizhongX
and removed request for
jgraham,
foolip and
DanielRyanSmith
WeizhongX
approved these changes
Apr 6, 2023
cookiecrook
pushed a commit
to cookiecrook/wpt
that referenced
this pull request
Apr 8, 2023
…atform-tests#39416) `tools.lint.lint` is unimportable when `git` does not exist in the `PATH`: ``` File "C:\b\s\w\ir\third_party\blink\tools\blinkpy\tool\commands\lint_wpt.py", line 16, in <module> from tools.lint import lint as wptlint File "C:\b\s\w\ir\third_party\wpt_tools\wpt\tools\lint\__init__.py", line 1, in <module> from . import lint # noqa: F401 File "C:\b\s\w\ir\third_party\wpt_tools\wpt\tools\lint\lint.py", line 1135, in <module> subprocess.check_output(["git", "--version"]) ... File "C:\b\s\w\ir\.task_template_vpython_cache\vpython\store\cpython-e6tenrlsesftvg6k08ajgkk7b4\contents\bin\Lib\subprocess.py", line 1311, in _execute_child hp, ht, pid, tid = _winapi.CreateProcess(executable, args, FileNotFoundError: [WinError 2] The system cannot find the file specified ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tools.lint.lintis unimportable whengitdoes not exist in thePATH: