-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use better assertions for computedrole #39618
Use better assertions for computedrole #39618
Conversation
@jcsteh looks like Gecko is failing the new "main" role test. Would you like to suggest another innocuous one for this webdriver test, since that specific role failure is already tested in /html-aam/role/roles.html? Perhaps |
ComputedRole is currently pretty broken in Gecko, as it exposes our internal role strings rather than standardised ARIA roles. I've been working on this and I have a bunch of patches up for review to fix it. Once those land, this test should pass. That said, |
Gecko fails for |
Comments crossed. I will try |
Confirmed Gecko passes the Okay to merge once @patrickangle or @AutomatedTester reviews. |
This doesn't require review from all the people marked as reviewers. In particular if the people working on a11y are happy with this change, and it doesn't also require a WebDriver spec change, we should land it without review from a WebDriver reviewer (if it does require a spec change we could still find a way to land it as a tentative test without WebDriver review, as long as there's a spec issue open). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the conversation, I think it's fine to approve this, as long as @jcsteh is happy with the change as well.
Resolves web-platform-tests#39118 Changes the WebDriver tests for computedrole to avoid some invalid tests. Note: The removed validation test are either already tests in /html-aam or /wai-aria, or are on the list to be written soon, so this should keep the WebDriver tests reliable without churn from unrelated accessibility changes. Reviewed by juliandescottes and jcsteh.
Resolves #39118
Replaces two invalid computedrole assertions which relied on an orphaned menuitem and a previously unspecified but now incorrect role synonym.
All three of the updated computedrole tests pass in WebKit and Chromium ( and Gecko soon), and this test effectively exercises the webdriver computedrole getter. Other disputed or erroneous tests that were removed here will be handled in /html-aam and /wai-aria/role
More detail in #39118