Implement consume_user_activation() web driver components

[marcoscaceres]

Matches the consume-user-activation WebDriver command, which corresponds to these steps in HTML: https://html.spec.whatwg.org/#consume-user-activation

[gsnedders]

I think this is my only comment here?

[gsnedders]

Can you instead just add this as a method somewhere on the WebDriver library (in tools/webdriver), rather than directly invoking the command?

[gsnedders]

Specifically, you probably want something like:

wpt/tools/webdriver/webdriver/client.py

Lines 361 to 363 in 7dcb66e

	@command
	def maximize(self):
	return self.session.send_session_command("POST", "window/maximize")

And then this becomes:

Suggested change

	return self.webdriver.send_session_command("POST", "consume-user-activation")
	return self.webdriver.window.consume_user_activation()

[gsnedders]

Also, isn't the command window/consume-user-activation?

[gsnedders]

Does this not need to take a context argument, from tools/wptrunner/wptrunner/executors/actions.py above? Because otherwise we're just outright ignoring the context argument specified in testdriver.js in the sole implementation.

[gsnedders]

Specifically, you probably want something like:

wpt/tools/webdriver/webdriver/client.py

Lines 361 to 363 in 7dcb66e

	@command
	def maximize(self):
	return self.session.send_session_command("POST", "window/maximize")

And then this becomes:

Suggested change

	return self.webdriver.send_session_command("POST", "consume-user-activation")
	return self.webdriver.window.consume_user_activation()

[gsnedders]

To summarise what I just posted:

• There's a context argument sometimes and not otherwise; it seems like you're currently just dropping it on the floor with the current implementation. I'd be happy to land this with no context argument (after all, that matches the WebDriver UX), which avoids needing to change much aside from the changing the JS side.
• Adding the command to the webdriver module.

Also, can you also add some test to /infrastructure/testdriver to verify the testdriver command works where expected?

[marcoscaceres]

The context definitely matters, because you can deactivate cross origin frames... I saw a lot of other things take a context but also don't use it on the python side (so I has assumed magic happened... but it's also sad that people are dropping context on the floor).

Anyway, yes! Let's get that context passed around!!

[gsnedders]

The context definitely matters, because you can deactivate cross origin frames... I saw a lot of other things take a context but also don't use it on the python side (so I has assumed magic happened... but it's also sad that people are dropping context on the floor).

Anyway, yes! Let's get that context passed around!!

it's plausible there's some magic somewhere, and I'm just unaware of it! digs around

seemingly ActionContext in tools/wptrunner/wptrunner/executors/base.py does this, ultimately.