Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML: pushState() url resolves against relevant settings object #41797

Merged
merged 1 commit into from
Sep 4, 2023
Merged

HTML: pushState() url resolves against relevant settings object #41797

merged 1 commit into from
Sep 4, 2023

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Sep 4, 2023

@zcorpan zcorpan requested a review from annevk September 4, 2023 08:20
@wpt-pr-bot wpt-pr-bot added the html label Sep 4, 2023
annevk
annevk approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay. How does this end up checking the encoding?

@annevk annevk mentioned this pull request Sep 4, 2023
Open
@zcorpan
Copy link
Member Author

zcorpan commented Sep 4, 2023

This line:

assert_true(got.indexOf(expected_current) > -1, msg(expected_current, got));

@zcorpan zcorpan enabled auto-merge (rebase) September 4, 2023 08:59
@zcorpan zcorpan merged commit 83a0e8b into master Sep 4, 2023
@zcorpan zcorpan deleted the zcorpan/pushState-relevant branch September 4, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@domenic domenic Awaiting requested review from domenic

@foolip foolip Awaiting requested review from foolip

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@foolip foolip

Labels
html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zcorpan @annevk @foolip @wpt-pr-bot