-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the AVIF test images render larger #41949
Make the AVIF test images render larger #41949
Conversation
At the moment, they're 2px x 2px images, which is kinda hard to notice on a large screen. Make this scale much larger, which should work fine.
There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While manually testing these I was previously using browser / page zoom, but this patch would make that unnecessary 👍
LGTM, with just a question: is there any reason to prefer style
over width
/height
for this purpose?
@@ -1 +1 @@ | |||
<img src=../images/green.avif> | |||
<img src=../images/green.avif style="height:500px"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, width=500 height=500
?
@@ -1,7 +1,7 @@ | |||
<html class="reftest-wait"> | |||
<title>Animated AVIF: Second frame displays quickly, replacing red with green.</title> | |||
<link rel="match" href="animated-avif-timeout-ref.html"/> | |||
<img src=../images/animated-avif.avif onload="loaded()"/> | |||
<img src=../images/animated-avif.avif onload="loaded()" style="height:500px"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
I no longer know. |
Ack. Either way it doesn’t matter for these tests so let’s just land this. Thanks! |
At the moment, they're 2px × 2px images, which is kinda hard to notice on a large screen. Make this scale much larger, which should work fine.
At the moment, they're 2px × 2px images, which is kinda hard to notice on a large screen. Make this scale much larger, which should work fine.
At the moment, they're 2px x 2px images, which is kinda hard to notice on a large screen. Make this scale much larger, which should work fine.