Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the AVIF test images render larger #41949

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

gsnedders
Copy link
Member

At the moment, they're 2px x 2px images, which is kinda hard to notice on a large screen. Make this scale much larger, which should work fine.

At the moment, they're 2px x 2px images, which is kinda hard to notice
on a large screen. Make this scale much larger, which should work fine.
@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you!

Copy link
Contributor

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While manually testing these I was previously using browser / page zoom, but this patch would make that unnecessary 👍

LGTM, with just a question: is there any reason to prefer style over width/height for this purpose?

@@ -1 +1 @@
<img src=../images/green.avif>
<img src=../images/green.avif style="height:500px">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, width=500 height=500?

@@ -1,7 +1,7 @@
<html class="reftest-wait">
<title>Animated AVIF: Second frame displays quickly, replacing red with green.</title>
<link rel="match" href="animated-avif-timeout-ref.html"/>
<img src=../images/animated-avif.avif onload="loaded()"/>
<img src=../images/animated-avif.avif onload="loaded()" style="height:500px"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@gsnedders
Copy link
Member Author

LGTM, with just a question: is there any reason to prefer style over width/height for this purpose?

I no longer know. width/height does stuff to the intrinsic ratio, does it not?

@mathiasbynens
Copy link
Contributor

LGTM, with just a question: is there any reason to prefer style over width/height for this purpose?

I no longer know. width/height does stuff to the intrinsic ratio, does it not?

Ack. Either way it doesn’t matter for these tests so let’s just land this. Thanks!

@mathiasbynens mathiasbynens merged commit 10645f3 into web-platform-tests:master Sep 13, 2023
@gsnedders gsnedders deleted the avif-bigger branch September 13, 2023 10:47
OrKoN pushed a commit that referenced this pull request Sep 18, 2023
At the moment, they're 2px × 2px images, which is kinda hard to notice
on a large screen. Make this scale much larger, which should work fine.
Lightning00Blade pushed a commit to Lightning00Blade/wpt that referenced this pull request Dec 11, 2023
At the moment, they're 2px × 2px images, which is kinda hard to notice
on a large screen. Make this scale much larger, which should work fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants