AccName: Name From Contents Tests #42354
Conversation
…r may be spec probs)
cookiecrook
requested review from
spectranaut,
jnurthen,
scottaohara,
MelSumner,
howard-e and
rahimabdi
|
Would it be useful to add tests on whether whitespace should be added around |
You're probably right, but we should add tests after an issue resolution, or at least in another PR after this one lands. (A lot more of grid/flex needs to be tested for accessibility.) Will you file a new AccName issue? There are a bunch of outstanding issues in the AccName whitespace project. Given that CSS will continue to change, I'd rather a term be defined by the CSS editors, and cross-referenced in ARIA. Even the [Update: I previously linked some related, but separate issues.] |
While not formalized in the AccName spec yet, there are discussions about adding white-space around inline-block elements. - w3c/accname#205 - w3c/accname#15 - w3c/accname#3 This change will make Chromium add whitespace around inline-block, inline-grid, inline-table, and inline-flex elements when computing Name from Content. This will let us pass the WPT tests that are in progress of being written: web-platform-tests/wpt#42354 Notes: - The WPT tests only mention inline-block, and there is no mention of the other inline-* properties yet. I think it's OK that this patch adds whitespace around other inline-* display properties (probably moreso than inline-block) because those properties define special formatting rules for their children, but let me know if you disagree and I can special-case this logic for inline-block. - It seems that <math> elements have an AtomicInline display type, similar to the other inline-* display types. This means that we start outputting whitespace around <math> elements when computing name from content as well. This feels fine, but as before, let me know if you disagree and I can hardcode what cases are OK. (As an aside, something seems broken with Name from Content when children are MathML? It's preexisting, and should probably be fixed in another CL) Change-Id: I2a4fc3cf137de5167d160860c1bda5151b38277d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4921470 Commit-Queue: Aaron Leventhal <[email protected]> Reviewed-by: Aaron Leventhal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1207629}
Co-authored-by: Rahim Abdi New tests for the "name from content" portions of the AccName "name computation" algorithm.
Closes web-platform-tests/interop-accessibility#36