Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create wai-aria/role/contextual-roles.html #42412

Merged
merged 31 commits into from
Oct 16, 2023

Conversation

rahimabdi
Copy link
Contributor

Copy link
Contributor

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry I didn't anticipate how many of these subtests would already be tested in other files. IIRC, I wrote the issue before those PRs were added.

You have lots of new tests here though, so any that aren't already tested could be moved to those related files, like tab-roles.html, list-roles.html, etc. I see at least a few that don't have another logical landing place, so keep those here?

wai-aria/role/contextual-roles.html Outdated Show resolved Hide resolved
wai-aria/role/contextual-roles.html Outdated Show resolved Hide resolved
wai-aria/role/contextual-roles.html Outdated Show resolved Hide resolved
wai-aria/role/contextual-roles.html Outdated Show resolved Hide resolved
wai-aria/role/contextual-roles.html Outdated Show resolved Hide resolved
wai-aria/role/contextual-roles.html Outdated Show resolved Hide resolved
wai-aria/role/contextual-roles.html Outdated Show resolved Hide resolved
wai-aria/role/contextual-roles.html Outdated Show resolved Hide resolved
wai-aria/role/contextual-roles.html Outdated Show resolved Hide resolved
wai-aria/role/contextual-roles.html Outdated Show resolved Hide resolved
Copy link
Contributor Author

@rahimabdi rahimabdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some table-related work remains, will get on that...

wai-aria/role/table-roles.html Outdated Show resolved Hide resolved
@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/Vew4DUK1S9a8aCVjpX_wzw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/Vew4DUK1S9a8aCVjpX_wzw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-10-13T23:20:23.061Z

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/XEpg-xZoRtmXCQLeRCd6sg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/XEpg-xZoRtmXCQLeRCd6sg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-10-13T23:20:30.752Z

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/A2UejhYKS8u-YQ8ZncmzaA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/A2UejhYKS8u-YQ8ZncmzaA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-10-13T23:20:33.244Z

@cookiecrook
Copy link
Contributor

As far as I can tell from digging through all the logs, this sink task is failing because ChromeDriver isn't downloading... It ran okay in Firefox and Safari, so why are the chrome-dev tests blocking the required sink-task check?

tools.wpt.browser.DownloadNotFoundError: No ChromeDriver download found to match browser version 120.0.6062.2 dev

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/Vew4DUK1S9a8aCVjpX_wzw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/Vew4DUK1S9a8aCVjpX_wzw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-10-15T23:28:23.589Z

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/XEpg-xZoRtmXCQLeRCd6sg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/XEpg-xZoRtmXCQLeRCd6sg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-10-15T23:28:26.617Z

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/A2UejhYKS8u-YQ8ZncmzaA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/A2UejhYKS8u-YQ8ZncmzaA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-10-15T23:28:29.896Z

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/GCZwXPczRS2siO0SgHJRDw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/GCZwXPczRS2siO0SgHJRDw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-10-15T23:28:35.426Z

@gsnedders
Copy link
Member

As far as I can tell from digging through all the logs, this sink task is failing because ChromeDriver isn't downloading... It ran okay in Firefox and Safari, so why are the chrome-dev tests blocking the required sink-task check?

tools.wpt.browser.DownloadNotFoundError: No ChromeDriver download found to match browser version 120.0.6062.2 dev

c.f. #42545

The Firefox job also blocks the sink task; the Safari one doesn't because historically Azure Pipelines has been too flaky to be reliable.

We probably are overly eager to assume that a failure is caused by the PR and not by some browser vendor messing up their release process and it being impossible to download the browser/webdriver binary, but it's probably quite difficult to detect that specifically.

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/A2UejhYKS8u-YQ8ZncmzaA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/A2UejhYKS8u-YQ8ZncmzaA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-10-16T20:07:11.782Z

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/XEpg-xZoRtmXCQLeRCd6sg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/XEpg-xZoRtmXCQLeRCd6sg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-10-16T20:07:15.805Z

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/Vew4DUK1S9a8aCVjpX_wzw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/Vew4DUK1S9a8aCVjpX_wzw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-10-16T20:07:18.287Z

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/GCZwXPczRS2siO0SgHJRDw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/GCZwXPczRS2siO0SgHJRDw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-10-16T20:07:21.540Z

@cookiecrook
Copy link
Contributor

We probably are overly eager to assume that a failure is caused by the PR and not by some browser vendor messing up their release process and it being impossible to download the browser/webdriver binary, but it's probably quite difficult to detect that specifically.

Thanks @gsnedders. So now that the need for the workaround is resolved, how should we re-trigger the tests? The re-run buttons seem to fail still.

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/GCZwXPczRS2siO0SgHJRDw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/GCZwXPczRS2siO0SgHJRDw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-10-16T20:09:41.693Z

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/Vew4DUK1S9a8aCVjpX_wzw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/Vew4DUK1S9a8aCVjpX_wzw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-10-16T20:09:45.104Z

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/XEpg-xZoRtmXCQLeRCd6sg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/XEpg-xZoRtmXCQLeRCd6sg",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-10-16T20:09:47.113Z

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/A2UejhYKS8u-YQ8ZncmzaA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/A2UejhYKS8u-YQ8ZncmzaA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-10-16T20:09:48.951Z

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/GCZwXPczRS2siO0SgHJRDw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw/GCZwXPczRS2siO0SgHJRDw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/Qj3wle4_S36gA6LRx-0Wcw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-10-16T20:09:56.062Z

@cookiecrook
Copy link
Contributor

Hold off on more re-run attempts until after @gsnedders can respond to #42412 (comment)

@cookiecrook
Copy link
Contributor

Attempting to re-run the full CI suite by closing and re-opening.

@cookiecrook cookiecrook reopened this Oct 16, 2023
@cookiecrook cookiecrook merged commit 48ef999 into master Oct 16, 2023
16 checks passed
@cookiecrook cookiecrook deleted the rahim/aria-contextual-roles-tests branch October 16, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contextual role invalidations tests
4 participants