Move popover=hint related code out of non-tentative test #43436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 29, 2023
3 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5074321
branch
from
6ed9f76 to
1a3167d
Compare
This refactors the test logic into a shared JS file and splits the popover=hint test code into a new .tentative.html file. Per this comment: web-platform-tests/interop#423 (comment) Bug: 1416284 Change-Id: Idda2716c476cf3d9b8fea724ece6e48d66e1fb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5074321 Auto-Submit: Mason Freed <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1234222}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5074321
branch
from
1a3167d to
9490a13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the test logic into a shared JS file and splits
the popover=hint test code into a new .tentative.html file.
Per this comment:
web-platform-tests/interop#423 (comment)
Bug: 1416284
Change-Id: Idda2716c476cf3d9b8fea724ece6e48d66e1fb62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5074321
Auto-Submit: Mason Freed <[email protected]>
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1234222}