Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[html] Remove a testcase to check case-insensitivity of radio button … #4374

Merged
merged 2 commits into from
Dec 21, 2016

Conversation

tkent-google
Copy link
Contributor

…group name

The testcase doesn't match to the current specification, and
radio-groupname-case.html covers this feature.

…group name

The testcase doesn't match to the current specification, and
radio-groupname-case.html covers this feature.
@wpt-pr-bot
Copy link
Collaborator

@tkent-google
Copy link
Contributor Author

@domenic @TakayoshiKochi , would you review this please?

@wpt-stability-bot
Copy link

wpt-stability-bot commented Dec 21, 2016

Firefox

Testing revision 9181e70
Starting 10 test iterations
All results were stable

All results

/html/semantics/forms/the-input-element/radio.html

Subtest Results
OK
canceled activation steps on unchecked radio PASS
only one control of a radio button group can have its checkedness set to true PASS
changing the name of a radio input element and setting its checkedness to true makes all the other elements' checkedness in the same radio button group be set to false PASS
click on mutable radio fires click event, then input event, then change event PASS
click on non-mutable radio doesn't fire the change event PASS
click on non-mutable radio doesn't fire the input event PASS
radio inputs with non-ASCII name attributes belong to the same radio button group PASS

@wpt-stability-bot
Copy link

wpt-stability-bot commented Dec 21, 2016

Chrome

Testing revision 9181e70
Starting 10 test iterations
All results were stable

All results

/html/semantics/forms/the-input-element/radio.html

Subtest Results
OK
canceled activation steps on unchecked radio PASS
only one control of a radio button group can have its checkedness set to true PASS
changing the name of a radio input element and setting its checkedness to true makes all the other elements' checkedness in the same radio button group be set to false PASS
click on mutable radio fires click event, then input event, then change event FAIL
click on non-mutable radio doesn't fire the change event PASS
click on non-mutable radio doesn't fire the input event PASS
radio inputs with non-ASCII name attributes belong to the same radio button group PASS

@zcorpan
Copy link
Member

zcorpan commented Dec 21, 2016

Can you change it so radio3 and radio4 both have the name groüp2?

radio-groupname-case.html doesn't test that two controls with the same name with non-ASCII characters are in the same group, as far as I can tell.

@tkent-google
Copy link
Contributor Author

@zcorpan thank you for the comment. New commit addressed it.

@zcorpan zcorpan merged commit c247c88 into master Dec 21, 2016
@zcorpan zcorpan deleted the tkent-fix-radio branch December 21, 2016 09:02
@zcorpan
Copy link
Member

zcorpan commented Dec 21, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants