WebKit export of https://bugs.webkit.org/show_bug.cgi?id=242685 #44080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cookiecrook
requested changes
Jan 19, 2024
html-aam/roles-contextual.html
Outdated
Comment on lines
43
to
46
| <main> | ||
| <header data-testname="el-header-ancestormain" data-expectedrole="generic" class="ex">x</header> | ||
| </main> | ||
|
|
There was a problem hiding this comment.
You need to use class="ex-generic" (without an expectedrole expando) or this will cause bogus failures in Chromium or Gecko.
There was a problem hiding this comment.
See the generic header-inside-nav test that is immediately preceding this one.
There was a problem hiding this comment.
There was a problem hiding this comment.
Done. Thanks for the review!
joone
force-pushed
the
wpt-export-for-webkit-242685
branch
from
f46af24 to
23239c6
Compare
cookiecrook
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebKit export from bug: AX: Header elements inside main elements should not be banner landmarks