Rename inset-area to position-area #47484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the CSSWG, this property has been renamed: w3c/csswg-drafts#10209 (comment) This does a mechanical rename: - `inset-area` to `position-area` - `insetArea` to `positionArea` - `InsetArea` to `PositionArea` - `inset_area` to `position_Area` After the mechanical rename, there were a handful of hand-fixups, e.g. in cases where the old property (inset-area) needs to stay, or in setting up feature access to both. This CL also adds a surrogate from `inset-area` to `position-area`, so that both names keep working. Separate runtime flags are created to enable either of these property names. As-is, `inset-area` is enabled for "stable", and `position-area` is "experimental". And finally, a virtual test suite is added that enables `inset-area` and disables `position-area` and tests that the old WPTs still pass. Note that the WPTs had to be slightly modified for their new copied location within the VTS. Bug: 352333393 Change-Id: I92d3347ae109546a155771a21b5d6aee2a81391d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5698212 Commit-Queue: Rune Lillesveen <[email protected]> Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Mason Freed <[email protected]> Auto-Submit: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1337930}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5698212
branch
from
45cbc49 to
6fca764
Compare
wpt-pr-bot
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the CSSWG, this property has been renamed:
w3c/csswg-drafts#10209 (comment)
This does a mechanical rename:
inset-areatoposition-areainsetAreatopositionAreaInsetAreatoPositionAreainset_areatoposition_AreaAfter the mechanical rename, there were a handful of hand-fixups,
e.g. in cases where the old property (inset-area) needs to stay,
or in setting up feature access to both.
This CL also adds a surrogate from
inset-areatoposition-area,so that both names keep working. Separate runtime flags are created
to enable either of these property names. As-is,
inset-areaisenabled for "stable", and
position-areais "experimental". Andfinally, a virtual test suite is added that enables
inset-areaand disables
position-areaand tests that the old WPTs still pass.Note that the WPTs had to be slightly modified for their new copied
location within the VTS.
Bug: 352333393
Change-Id: I92d3347ae109546a155771a21b5d6aee2a81391d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5698212
Commit-Queue: Rune Lillesveen <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Commit-Queue: Mason Freed <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1337930}