Fetch KeepAlive Quota Tests #4878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial add of quota tests for keepalive fetch requests.
|
Notifying @jdm and @youennf. (Learn how reviewing works.) |
Chrome (unstable channel)Testing web-platform-tests at revision 9e878bd All results1 test ran/fetch/api/request/request-keepalive-quota.html
|
Firefox (nightly channel)Testing web-platform-tests at revision 9e878bd All results1 test ran/fetch/api/request/request-keepalive-quota.html
|
|
Thanks, I already reviewed these in #4788 and they still look good. I'd like to land them together with whatwg/fetch#419 which still needs a bit of rebasing work. |
annevk
pushed a commit
to whatwg/fetch
that referenced
this pull request
Feb 25, 2017
Requests with keepalive flag set are allowed to outlive the environment settings object. We want to make sure that such requests do not negatively impact the user experience when a page is unloaded, etc. This limits the amount of (body) bytes that can be inflight at any point when the request has the keepalive flag set; this flag is also set by sendBeacon(). Background: w3c/beacon#39. Tests: web-platform-tests/wpt#4878.
|
Thanks again for writing these! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial add of quota tests for keepalive fetch requests.