[resources] Wait for document.fonts.ready in checkLayout() tests
#49556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements most of web-platform-tests/rfcs#213 and fixes up tests that use `checkLayout()` with extra `test()`s or other synchronous code, which now have to live in `promise_setup()` or `promise_test()`s to be part of the promise test queue. A follow-up PR will clean up obsolete `document.fonts.ready.then(() => checkLayout(...)`.
jonathan-j-lee
force-pushed
the
check-layout/wait-for-web-fonts
branch
from
228017f to
282130f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements most of web-platform-tests/rfcs#213 and fixes up tests that use
checkLayout()with extratest()s or other synchronous code, which now have to live inpromise_setup()orpromise_test()s to be part of the promise test queue.A follow-up PR will clean up obsolete
document.fonts.ready.then(() => checkLayout(...)).