Create optgroup-name-desc.tentative.html #49645
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to automatically test names for optgroup within a custom styled select element. expectations for fallback descriptions provided in markup comments
|
@smhigley to review |
josepharhar
reviewed
Dec 12, 2024
| <select> | ||
| <button><selectedcontent></selectedcontent></button> | ||
| <optgroup aria-labelledby=f data-testname="optgroup aria-labelledby" data-expectedlabel="foo" class="ex"> | ||
| <div id=f>foo</div> <!-- invalid per content model --> |
There was a problem hiding this comment.
This div is just invalid because it has text in it, right?
There was a problem hiding this comment.
added a comment on 254 to call out an instance of an empty div as being valid under the content model
cookiecrook
reviewed
Dec 12, 2024
scottaohara
commented
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to automatically test names for optgroup within a custom styled select element.
expectations for fallback descriptions provided in markup comments