Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tentative: match new PR about 2E "unless the element is marked as presentational" #50002

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

giacomo-petri
Copy link
Contributor

@giacomo-petri giacomo-petri commented Jan 9, 2025

Closes: web-platform-tests/interop-accessibility#167

Relates and match: w3c/aria#2405

Ambiguity: https://www.w3.org/TR/accname-1.2/#comp_host_language_label

This PR adds tests for:

  • elements receiving the accessible name from host language label elements (both explicit and implicit) with role="presentation";
  • elements with role=presentation that do not receive the accessible name from host language label elements (both explicit and implicit)
  • elements with role=presentation that receives the accessible name from host language label elements (both explicit and implicit) due to presentational roles conflict resolution

Note: since I created tests for acc name related to presentational roles conflict resolution, I have also included tests to verify that the computed role aligns with the expected result.

@giacomo-petri giacomo-petri changed the title input elements receiving the accessible name from label elements (both explicit and implicit) with role="presentation" Tentative: match new PR about 2E "unless the element is marked as presentational" Jan 11, 2025
<h2>HTML input with role="none" and label associated (presentational roles conflict resolution)</h2>
<h3>HTML input label/for</h3>
<label for="irn">input label</label>
<input id="irn" type="text" data-expectedlabel="input label" data-testname="html: label[for]input[role presentation]" class="ex" role="presentation">
Copy link

@lolaodelola lolaodelola Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @giacomo-petri, should the input here have a role="none" or are you using role="presentation" interchangeably?

<h2>HTML input with role="none" and label with role presentation (presentational roles conflict resolution)</h2>
<h3>HTML input label/for</h3>
<label role="presentation" for="lirp">input label</label>
<input id="lirp" type="text" data-expectedlabel="input label" data-testname="html: label[for][role presentation] input[role presentation]" class="ex" role="presentation">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. The heading indicates this is testing for a label with role="presentation" and input with role="none" but the input here is role="presentation".

@lolaodelola
Copy link

Hi @giacomo-petri, I'm coming from the review of PR 2405. This looks good to me for the most part, Scott's addressed some of the initial confusion. I noted some semantic confusion in the naming of the test sections vs what is being tested. While role="presentation" and role="none" do the same thing, it's confusing to have the test refer to testing role="none" on an input but the actual test setup has role="presentation" on the input. In most cases where you mention testing for none, you're testing for presentation, I didn't want to litter your inbox with every instance of this but I've noted two above.

Unless there's something I'm missing, the heading and test setup should match to avoid confusion for folks when reading.

Thank you for this work!

@giacomo-petri
Copy link
Contributor Author

Done

@lolaodelola
Copy link

Thanks @giacomo-petri! You have some lint errors, once you've addressed those I'll be happy to approve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label element with role presentation and accname Host Language Label
4 participants