2DContext: Set up tests for new signature of imageData functions #5180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{get,put,create}imageData() functions are reverting from double to long.
Added/cleaned up tests for dealing with float inputs.
Relevant discussion: whatwg/html#2433
|
Notifying @gsnedders. (Learn how reviewing works.) |
fserb
added a commit
to fserb/html
that referenced
this pull request
Mar 20, 2017
ImageData()'s double arguments had undefined behavior and implementation incompatibilities. Reverting it to long makes it well defined. Fixes whatwg#2433. Tests: * web-platform-tests/wpt#5180
Firefox (nightly channel)Testing web-platform-tests at revision 7f3069c All results4 tests ran/2dcontext/pixel-manipulation/2d.imageData.create2.double.html
/2dcontext/pixel-manipulation/2d.imageData.create2.zero.html
/2dcontext/pixel-manipulation/2d.imageData.get.double.html
/2dcontext/pixel-manipulation/2d.imageData.get.zero.html
|
Chrome (unstable channel)Testing web-platform-tests at revision 7f3069c All results4 tests ran/2dcontext/pixel-manipulation/2d.imageData.create2.double.html
/2dcontext/pixel-manipulation/2d.imageData.create2.zero.html
/2dcontext/pixel-manipulation/2d.imageData.get.double.html
/2dcontext/pixel-manipulation/2d.imageData.get.zero.html
|
annevk
reviewed
Mar 21, 2017
| @@ -1,28 +1,30 @@ | |||
| <!DOCTYPE html> | |||
| <!-- DO NOT EDIT! This test has been generated by tools/gentest.py. --> | |||
There was a problem hiding this comment.
I don't see an update to this tool. Am I missing something or is this direct modification of these tests the wrong way to go?
There was a problem hiding this comment.
they come from the tests2d.yaml files
There was a problem hiding this comment.
also note we'd get a CI failure if it was modifying only the generated files
fserb
added a commit
to fserb/html
that referenced
this pull request
Mar 21, 2017
ImageData()'s double arguments had undefined behavior and implementation incompatibilities. Reverting it to long makes it well defined. Fixes whatwg#2433. Tests: * web-platform-tests/wpt#5180
annevk
pushed a commit
to whatwg/html
that referenced
this pull request
Mar 22, 2017
getImageData(), putImageData(), and createImageData() double arguments had undefined behavior and implementation incompatibilities. Reverting them back to long makes it well defined. Tests: web-platform-tests/wpt#5180. Fixes #2433.
alice
pushed a commit
to alice/html
that referenced
this pull request
Jan 8, 2019
getImageData(), putImageData(), and createImageData() double arguments had undefined behavior and implementation incompatibilities. Reverting them back to long makes it well defined. Tests: web-platform-tests/wpt#5180. Fixes whatwg#2433.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{get,put,create}imageData() functions are reverting from double to long.
Added/cleaned up tests for dealing with float inputs.
Relevant discussion: whatwg/html#2433