Add tests for the messageerror IDL attribute in service workers #5628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows w3c/ServiceWorker#1130. The actual situations in which this will be called is being tested as part of #5003.
|
Notifying @ehsan, @mattto, and @mkruisselbrink. (Learn how reviewing works.) |
LintPassed |
Firefox (nightly channel)Testing web-platform-tests at revision ab1900f All results1 test ran/service-workers/service-worker/interfaces.https.html
|
Chrome (unstable channel)Testing web-platform-tests at revision ab1900f All results1 test ran/service-workers/service-worker/interfaces.https.html
|
Codecov Report
@@ Coverage Diff @@
## master #5628 +/- ##
=======================================
Coverage 87.22% 87.22%
=======================================
Files 24 24
Lines 2418 2418
Branches 406 406
=======================================
Hits 2109 2109
Misses 239 239
Partials 70 70Continue to review full report at Codecov.
|
foolip
added a commit
to foolip/ServiceWorker
that referenced
this pull request
Apr 24, 2017
The wording is adapted from the WHATWG contributor guidelines: https://github.com/whatwg/meta/blob/master/CONTRIBUTING.md This is sometimes already happening: web-platform-tests/wpt#3449 web-platform-tests/wpt#5628 Drive-by: whitespace
foolip
added a commit
to foolip/ServiceWorker
that referenced
this pull request
Apr 26, 2017
The wording is adapted from the WHATWG contributor guidelines: https://github.com/whatwg/meta/blob/master/CONTRIBUTING.md This is sometimes already happening: web-platform-tests/wpt#3449 web-platform-tests/wpt#5628 Drive-by: whitespace
jungkees
pushed a commit
to w3c/ServiceWorker
that referenced
this pull request
Apr 26, 2017
The wording is adapted from the WHATWG contributor guidelines: https://github.com/whatwg/meta/blob/master/CONTRIBUTING.md This is sometimes already happening: web-platform-tests/wpt#3449 web-platform-tests/wpt#5628 Drive-by: whitespace
|
lgtm (I wonder why we still have these instead of idlharness...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows w3c/ServiceWorker#1130. The actual situations in which this will be called is being tested as part of #5003.
This change is