Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Modify errors from try server," #7585

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Conversation

foolip
Copy link
Member

@foolip foolip commented Oct 5, 2017

This reverts commit 05e8454.

This appears to have been an accident, see
#7531 (comment)

This reverts commit 05e8454.

This appears to have been an accident, see
#7531 (comment)
@wpt-pr-bot
Copy link
Collaborator

There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@foolip
Copy link
Member Author

foolip commented Oct 5, 2017

@mikewest, actually, these aren't tests, and look like unused files. Maybe deleting these was the right thing to do?

@ghost
Copy link

ghost commented Oct 5, 2017

Build PASSED

Started: 2017-10-05 06:32:08
Finished: 2017-10-05 06:41:42

View more information about this build on:

@mikewest
Copy link
Member

mikewest commented Oct 5, 2017

Why aren't they tests? They look like tests to me?

@foolip
Copy link
Member Author

foolip commented Oct 5, 2017

Oh, they are, and they passed on at least Firefox. I thought .sub. was only used resource files because that's what I've seen a lot of.

So, these should be revived?

@Hexcles
Copy link
Member

Hexcles commented Oct 5, 2017

@jgraham also confirmed on IRC this was likely an accident https://logs.csswg.org/irc.w3.org/testing/2017-10-03/#e885259

We should definitely try to detect such cases in the (future) audit tool.

@mikewest
Copy link
Member

mikewest commented Oct 5, 2017

Yes! Please don't delete my tests without putting them back afterwards. :)

This patch LGTM (and .sub. totally works on main resources). :)

Copy link
Member

@Hexcles Hexcles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try if I can rubber stamp. :)

@Hexcles Hexcles merged commit b4f9964 into master Oct 5, 2017
@Hexcles Hexcles deleted the revive-cookies-tests branch October 5, 2017 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants