-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Modify errors from try server," #7585
Conversation
This reverts commit 05e8454. This appears to have been an accident, see #7531 (comment)
There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
@mikewest, actually, these aren't tests, and look like unused files. Maybe deleting these was the right thing to do? |
Build PASSEDStarted: 2017-10-05 06:32:08 View more information about this build on: |
Why aren't they tests? They look like tests to me? |
Oh, they are, and they passed on at least Firefox. I thought .sub. was only used resource files because that's what I've seen a lot of. So, these should be revived? |
@jgraham also confirmed on IRC this was likely an accident https://logs.csswg.org/irc.w3.org/testing/2017-10-03/#e885259 We should definitely try to detect such cases in the (future) audit tool. |
Yes! Please don't delete my tests without putting them back afterwards. :) This patch LGTM (and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me try if I can rubber stamp. :)
This reverts commit 05e8454.
This appears to have been an accident, see
#7531 (comment)