Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature-policy to battery-status #7944

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Add feature-policy to battery-status #7944

merged 2 commits into from
Sep 25, 2019

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Oct 23, 2017 •
edited by wpt-pr-bot
Loading

  • Add feature-policy tests
  • Disallow using battery in cross-origin iframe
  • Allow using battery in same-origin iframe

Reflect to w3c/battery#13

@Honry Honry mentioned this pull request Oct 23, 2017
Merged
@ghost
Copy link

ghost commented Oct 23, 2017 •
edited by ghost
Loading

Build PASSED

Started: 2017-10-23 12:22:19
Finished: 2017-10-23 12:56:17

View more information about this build on:

anssiko
anssiko approved these changes Oct 23, 2017
View reviewed changes
Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@clelland to review the Feature Policy tests to ensure we've tested the edge cases correctly.

@anssiko anssiko mentioned this pull request Oct 23, 2017
Merged
@anssiko anssiko mentioned this pull request May 15, 2018
Merged
@gsnedders
Copy link
Member

Is there any reason this hasn't landed? Or are we waiting on @clelland to review half of this?

(Also, this now needs rebased given the OWNERS/META.yml migration, see #9230.)

@Honry
Copy link
Contributor Author

Honry commented Sep 4, 2018

@gsnedders, actually this PR reflects to w3c/battery#13, which is still under review. And I will rebase it soon.

@Honry Honry force-pushed the battery/feature-policy branch from f66e903 to bbc1fbf Compare September 4, 2018 01:28
@Honry
Add feature-policy to battery-status
dfa3f0f 
 - Add feature-policy tests
 - Disallow using battery in cross-origin iframe
 - Allow using battery in same-origin iframe
 w3c/battery#13
@Honry
Replace SecurityError with NotAllowedError
aafaab9 
and use modern ES6
@Honry Honry force-pushed the battery/feature-policy branch from bbc1fbf to aafaab9 Compare September 25, 2019 11:54
@Honry
Copy link
Contributor Author

Honry commented Sep 25, 2019 •
edited
Loading

@anssiko, tests have been up-to-date, PTAL again. Thanks!

@anssiko
Copy link
Member

anssiko commented Sep 25, 2019

Thanks @Honry, LGTM!

(The only normative change since last update to this PR was w3c/battery@3e08915 and that's now baked into this PR.)

@Honry Honry merged commit fab60f6 into web-platform-tests:master Sep 25, 2019
@Honry Honry deleted the battery/feature-policy branch September 25, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anssiko anssiko anssiko approved these changes

@clelland clelland Awaiting requested review from clelland

@dontcallmedom dontcallmedom Awaiting requested review from dontcallmedom

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@anssiko anssiko

Labels
battery-status feature-policy status:needs-spec-decision wg-dap wg-das wg-webappsec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Honry @gsnedders @anssiko @wpt-pr-bot