[css-typed-om] Fix computed value of an interpolated transform. #9731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 1, 2018
Build PASSEDStarted: 2018-03-01 19:49:07 View more information about this build on: |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-942595
branch
from
4e32298 to
4ffe185
Compare
Previously we did not handle the case of computing the value of an interpolated transform, which occurs when we interpolate between two different transform types containing percentages. The correct result is currently not spec'd [1], so this patch fixes this by just returning "none" in this case. [1] w3c/css-houdini-drafts#425 Bug: 816803 Change-Id: I97c8f6b71f651a8d547fb4cb307121eba7dabdb6 Reviewed-on: https://chromium-review.googlesource.com/942595 Reviewed-by: nainar <[email protected]> Commit-Queue: Darren Shen <[email protected]> Cr-Commit-Position: refs/heads/master@{#540258}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-942595
branch
from
4ffe185 to
dfec93f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we did not handle the case of computing the value of an
interpolated transform, which occurs when we interpolate between
two different transform types containing percentages.
The correct result is currently not spec'd [1], so this patch fixes this
by just returning "none" in this case.
[1] w3c/css-houdini-drafts#425
Bug: 816803
Change-Id: I97c8f6b71f651a8d547fb4cb307121eba7dabdb6
Reviewed-on: https://chromium-review.googlesource.com/942595
Reviewed-by: nainar [email protected]
Commit-Queue: Darren Shen [email protected]
Cr-Commit-Position: refs/heads/master@{#540258}