Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce size of install #207

Closed
gauntface opened this issue Aug 30, 2016 · 6 comments
Closed

Reduce size of install #207

gauntface opened this issue Aug 30, 2016 · 6 comments
Assignees
@marco-c

Comments

@gauntface
Copy link

See : https://twitter.com/borismus/status/770456100235726849 from @borismus
@marco-c marco-c mentioned this issue Aug 30, 2016
Closed
@marco-c
Copy link
Member

marco-c commented Aug 30, 2016

Maybe we could find a way to make the dependencies needed to support older Node.js versions optional.

@marco-c
Copy link
Member

marco-c commented Aug 30, 2016

Another idea is to create PR to our dependencies to make them add a .npmignore file to avoid including tests in their packages, e.g. indutny/asn1.js#75.

This was referenced Sep 19, 2016
Merged
Closed
@marco-c marco-c mentioned this issue Oct 11, 2016
Merged
@marco-c
Copy link
Member

marco-c commented Oct 13, 2016

With the new http_ece we're under 1 MB.

@marco-c
Copy link
Member

marco-c commented Oct 13, 2016

List of packages where more files could be added to .npmignore: typedarray, minimist, jws, jwa, base64url. We would save around 135 kB.

@marco-c
Copy link
Member

marco-c commented Oct 13, 2016

https://github.com/substack/typedarray/pull/11
https://github.com/substack/minimist/pull/95
auth0/node-jws#60
auth0/node-jwa#15
brianloveswords/base64url#14

@marco-c marco-c self-assigned this May 11, 2019
@marco-c
Copy link
Member

marco-c commented May 11, 2019

I think we can call this fixed!

@marco-c marco-c closed this as completed May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marco-c marco-c

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gauntface @marco-c