Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exlude tests from package #14

Merged
merged 1 commit into from
Nov 25, 2018
Merged

Exlude tests from package #14

merged 1 commit into from
Nov 25, 2018

Conversation

marco-c
Copy link
Contributor

@marco-c marco-c commented Oct 13, 2016

No description provided.

@marco-c marco-c mentioned this pull request Oct 13, 2016
Closed
@fregante
Copy link

fregante commented Oct 13, 2016 •
edited
Loading

node_modules is excluded automatically, btw.

Also if you care about size, just use atob/btoa and their node counterparts

@marco-c
Copy link
Contributor Author

marco-c commented Oct 13, 2016

node_modules is excluded automatically, btw.

It was already there, so I didn't remove it.

Also if you care about size, just use atob/btoa and their node counterparts

I can't control dependencies of my dependencies.

MylesBorins
MylesBorins approved these changes Nov 25, 2018
View reviewed changes
Copy link
Collaborator

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianloveswords brianloveswords merged commit 204d66d into brianloveswords:master Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marco-c @fregante @MylesBorins @brianloveswords