-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Conversation
This is a nice idea, but would increase the package size for every user by the So better link to: |
@frozeman if you don't want to add That said, I think it's a good practice to ship the dist directory in the npm package. |
But shipping it in NPM grows it by a lot, i would prefer getting it from GitHub. Same for 1.0. |
It uses the latest release: https://github.com/ethereum/web3.js/releases |
That would be 1.0 version, not 0.20.x |
Actually it's 0.19 right now because beta releases are not considered when selecting the latest version: https://cdn.jsdelivr.net/gh/ethereum/web3.js/ |
And why not 0.20.6? Btw you want to adjust your PR? |
There isn't a 0.20.6 release on GitHub as far as I can see. |
Youre right i never created a release for that one. Will do. |
I added a jsDelivr CDN link to your readme, so that people can use it directly without bower or component. jsDelivr is the fastest open-source CDN and updates automatically from npm.
I also added dist folder to npm so that this continues to work after v1.0.0 is released.