Add bignumber.js to web3-core (for its types) #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, Travis is failing after I updated the branch. |
|
@holgerd77 I think Travis or mocha just ran one of the jobs too slowly - this happens fairly often :) It's possible to restart the job from the Travis UI using a button next to the failing item - usually passes second time. The "allowed failure" windows job (always times out) looks ok for this PR - it's running as expected and exiting 0 here. |
nivida
added
1.x
nivida
approved these changes
Feb 28, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #3213 @types/bignumber.js was removed - that package is now a stub and the main module implements its types internally.
However, bignumber.js is not a direct dependency here - it's only used for its types - and TS users currently see the error reported in #3386 about an unresolved import.
tsctests did not catch this because bignumber.js exists in the development dependency tree.bignumber.jsis imported inThis PR should not affect the bundle size.
Fixes #3386
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases do cover all lines and branches of the added code.npm run build-alland tested the resulting file/'s fromdistfolder in a browser.CHANGELOG.mdfile in the root folder.