-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite web3-eth-iban #3955
Rewrite web3-eth-iban #3955
Conversation
toString () { | ||
return this._iban; | ||
}; | ||
} | ||
|
||
module.exports = Iban; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left module.exports = Iban;
instead of export default Iban
to avoid breaking changes. What do you suggest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
module.exports is fine for this
Pull Request Test Coverage Report for Build 660165167
💛 - Coveralls |
This is good work! unfortunately it's failing test can take a look and see if i can help figure out why. |
1 check fails:
I see other PRs failing with the same issue coming from https://github.com/ChainSafe/web3.js/blob/2c5a8ec7bbb678b8e718a28fd5fec7709bacde25/scripts/js/basic_usage.js#L50 |
Description
Part of #3932
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.