Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 4.x Packages badges #5929

Merged
merged 5 commits into from
Mar 27, 2023
Merged

Conversation

Muhammad-Altabba
Copy link
Contributor

Description

Fixes #5406

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist for 1.x:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Checklist for 4.x:

  • I have selected the correct 4.x base branch.
  • Within the description, the feature or issue is discussed in detail or an issue is linked.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added any required tests for the changes I made
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules.
  • I ran yarn successfully
  • I ran yarn lint successfully
  • I ran yarn build:web successfully
  • I ran yarn test:unit successfully
  • I ran yarn test:integration successfully
  • I ran compile:contracts successfully
  • I have tested my code.
  • I have updated the corresponding CHANGELOG.md file in the packages I have edited.

@Muhammad-Altabba Muhammad-Altabba linked an issue Mar 15, 2023 that may be closed by this pull request
@Muhammad-Altabba Muhammad-Altabba changed the base branch from 1.x to 4.x March 15, 2023 21:42
@Muhammad-Altabba Muhammad-Altabba requested a review from a team as a code owner March 15, 2023 21:42
@github-actions
Copy link

github-actions bot commented Mar 15, 2023

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 1.06 MB 1.06 MB 971 bytes 0.09%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 1.05 MB 1.05 MB 971 bytes 0.09%
../lib/accounts.d.ts 3.42 KB 3.42 KB 0 0.00%
../lib/types.d.ts 1.68 KB 1.68 KB 0 0.00%
../lib/types.d.ts.map 1.51 KB 1.51 KB 0 0.00%
../lib/abi.d.ts 999 bytes 999 bytes 0 0.00%
../lib/index.d.ts.map 919 bytes 919 bytes 0 0.00%
../lib/index.d.ts 899 bytes 899 bytes 0 0.00%
../lib/web3.d.ts 842 bytes 842 bytes 0 0.00%
../lib/web3.d.ts.map 694 bytes 694 bytes 0 0.00%
../lib/accounts.d.ts.map 528 bytes 528 bytes 0 0.00%
../lib/eth.exports.d.ts.map 358 bytes 358 bytes 0 0.00%
../lib/eth.exports.d.ts 321 bytes 321 bytes 0 0.00%
../lib/providers.exports.d.ts.map 292 bytes 292 bytes 0 0.00%
../lib/providers.exports.d.ts 238 bytes 238 bytes 0 0.00%
../lib/version.d.ts.map 140 bytes 140 bytes 0 0.00%
../lib/abi.d.ts.map 124 bytes 124 bytes 0 0.00%
../lib/version.d.ts 97 bytes 97 bytes 0 0.00%

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #5929 (12b29da) into 4.x (c019149) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #5929   +/-   ##
=======================================
  Coverage   82.04%   82.04%           
=======================================
  Files         137      137           
  Lines        5983     5983           
  Branches     1572     1572           
=======================================
  Hits         4909     4909           
  Misses       1074     1074           
Flag Coverage Δ
UnitTests 82.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 15, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 12b29da
Status: ✅  Deploy successful!
Preview URL: https://408d86e3.web3-js-docs.pages.dev
Branch Preview URL: https://feature-5406-4x-packages-bad.web3-js-docs.pages.dev

View logs

@Muhammad-Altabba Muhammad-Altabba deleted the feature/5406/4x-packages-badges branch March 27, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.x Packages badges
6 participants