-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace private _config
with public config
in web3_config.ts
#5950
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with
|
Latest commit: |
39b5f2e
|
Status: | ✅ Deploy successful! |
Preview URL: | https://3bba7b24.web3-js-docs.pages.dev |
Branch Preview URL: | https://wyatt-4-x-5802-contract-web3.web3-js-docs.pages.dev |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #5950 +/- ##
==========================================
+ Coverage 82.04% 82.14% +0.09%
==========================================
Files 137 137
Lines 5983 5981 -2
Branches 1572 1572
==========================================
+ Hits 4909 4913 +4
+ Misses 1074 1068 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Issue #5802 was fixed by making
Web3Config.config
apublic
property instead of forcing the use of the getter methodgetConfig
(addresses the issue brought up in the beginning of this comment). I think ideally we'd want to keepWeb3Config.config
private
and replacegetConfig
andsetConfig
with a standard getter and setter, but this wouldn't fix #5802 becauseContract
spreads the providedWeb3Context
which causes providerOrContext to be a simple object rather than an instance ofWeb3Config
where the getter for_config
would be available. This could be accounted for, but in doing so a substantial amount of changes were needed and I opted to go the route of fewer changes to fix #5802Removed
web3-core
getConfig
method fromWeb3Config
class,config
is now public and accessible usingWeb3Config.config
(Replaceprivate _config
withpublic config
inweb3_config.ts
#5950)closes #5802