Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowing to specify percentage-based factors (like 1.125 for 112.5%) #7332

4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2744,3 +2744,7 @@ If there are any bugs, improvements, optimizations or any new feature proposal f
#### web3

- Exported EIP-6963 types are no longer under the `providers` namespace. (#7270)

#### web3-eth

- Allow specifying percentage based factor in Web3Eth.calculateFeeData Param baseFeePerGasFactor #7332
5 changes: 3 additions & 2 deletions packages/web3-eth/src/web3_eth.ts
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ export class Web3Eth extends Web3Context<Web3EthExecutionAPI, RegisteredSubscrip
* ```
*/
public async calculateFeeData(
baseFeePerGasFactor = BigInt(2),
baseFeePerGasFactor: number = 2,
TemirlanBasitov marked this conversation as resolved.
Show resolved Hide resolved
alternativeMaxPriorityFeePerGas = ethUnitMap.Gwei,
): Promise<FeeData> {
const block = await this.getBlock<{ number: FMT_NUMBER.BIGINT; bytes: FMT_BYTES.HEX }>(
Expand Down Expand Up @@ -348,7 +348,8 @@ export class Web3Eth extends Web3Context<Web3EthExecutionAPI, RegisteredSubscrip
// and we multiply the `baseFeePerGas` by `baseFeePerGasFactor`, to allow
// trying to include the transaction in the next few blocks even if the
// baseFeePerGas is increasing fast
maxFeePerGas = baseFeePerGas * baseFeePerGasFactor + maxPriorityFeePerGas;
const baseFeeMultiplier = BigInt(Math.floor(baseFeePerGasFactor * 1000)) / BigInt(1000);
TemirlanBasitov marked this conversation as resolved.
Show resolved Hide resolved
maxFeePerGas = baseFeePerGas * baseFeeMultiplier + maxPriorityFeePerGas;
}
TemirlanBasitov marked this conversation as resolved.
Show resolved Hide resolved

return { gasPrice, maxFeePerGas, maxPriorityFeePerGas, baseFeePerGas };
Expand Down
Loading