Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Link to SocketConstructorOpts Type #7363

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

danforbes
Copy link
Contributor

No description provided.

Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 646.7 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 627.18 kB 0%
../lib/commonjs/index.d.ts 8.72 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 1.06 kB 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: be17b88 Previous: efac906 Ratio
processingTx 22007 ops/sec (±7.56%) 23741 ops/sec (±5.98%) 1.08
processingContractDeploy 39391 ops/sec (±6.64%) 39369 ops/sec (±11.37%) 1.00
processingContractMethodSend 16551 ops/sec (±6.73%) 17405 ops/sec (±6.68%) 1.05
processingContractMethodCall 28231 ops/sec (±6.11%) 28770 ops/sec (±6.60%) 1.02
abiEncode 44204 ops/sec (±7.30%) 44377 ops/sec (±8.86%) 1.00
abiDecode 29687 ops/sec (±8.34%) 31118 ops/sec (±7.50%) 1.05
sign 1546 ops/sec (±3.47%) 1604 ops/sec (±0.56%) 1.04
verify 369 ops/sec (±0.50%) 369 ops/sec (±2.79%) 1

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.50%. Comparing base (efac906) to head (be17b88).
Report is 2 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7363   +/-   ##
=======================================
  Coverage   94.50%   94.50%           
=======================================
  Files         217      217           
  Lines        8487     8487           
  Branches     2343     2343           
=======================================
  Hits         8021     8021           
  Misses        466      466           
Flag Coverage Δ
UnitTests 94.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@danforbes danforbes merged commit 95b4bab into 4.x Oct 30, 2024
54 checks passed
@danforbes danforbes deleted the fix/docs/SocketConstructorOpts-link branch October 30, 2024 14:03
@luu-alex luu-alex mentioned this pull request Nov 6, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants