Broken with latest ember-cli (2.4.0) #121

holandes22 · 2016-03-01T08:21:01Z

After upgrading to ember-cli and ember 2.4.0 I started getting this error, preventing the build to run:

this.vendorStaticStyles.concat is not a function
TypeError: this.vendorStaticStyles.concat is not a function
    at EmberApp.styles (/home/pablo/projects/kube-admin/node_modules/ember-component-css/index.js:85:43)
    at EmberApp.toArray (/home/pablo/projects/kube-admin/node_modules/ember-cli/lib/broccoli/ember-app.js:1493:10)
    at EmberApp.toTree (/home/pablo/projects/kube-admin/node_modules/ember-cli/lib/broccoli/ember-app.js:1514:30)
    at module.exports (/home/pablo/projects/kube-admin/ember-cli-build.js:25:14)
    at Class.module.exports.Task.extend.setupBroccoliBuilder (/home/pablo/projects/kube-admin/node_modules/ember-cli/lib/models/builder.js:55:19)
    at Class.module.exports.Task.extend.init (/home/pablo/projects/kube-admin/node_modules/ember-cli/lib/models/builder.js:89:10)
    at new Class (/home/pablo/projects/kube-admin/node_modules/ember-cli/node_modules/core-object/core-object.js:18:12)
    at Class.module.exports.Task.extend.run (/home/pablo/projects/kube-admin/node_modules/ember-cli/lib/tasks/serve.js:15:19)
    at /home/pablo/projects/kube-admin/node_modules/ember-cli/lib/commands/serve.js:70:22
    at lib$rsvp$$internal$$tryCatch (/home/pablo/projects/kube-admin/node_modules/rsvp/dist/rsvp.js:493:16)

If I change line 82 at index.js to this

inputFiles: this.vendorStaticStyles['/assets/vendor.css'].concat(['vendor/addons.css']),

then is working again. I'm preparing a PR for this

Apparently the structure of this.vendorStaticStyles changed. Is this private API?

The text was updated successfully, but these errors were encountered:

nanuxbe · 2016-03-01T10:09:29Z

+1 same error, same fix works (except it's on line 85 not 82)

Exelord · 2016-03-01T13:55:25Z

+1

shillbom · 2016-03-01T15:33:07Z

This does not work for me on a new empty project.

For me this.vendorStaticStyles == {} so I get the following error:
Cannot read property 'concat' of undefined

Have i configured something wrong?

webark#121

cesarizu · 2016-03-01T18:36:26Z

The original method was changed considerably here: ember-cli/ember-cli@e78de54#diff-392bb207fea8bcbeb4a084bb445f7cc7R1170

webark · 2016-03-01T21:24:59Z

Ya. I feel that it's sad to say that this project is defunct.. :( Anyone have any luck with any other projects?

holandes22 · 2016-03-02T07:17:47Z

Just an update: ember-cli 2.4.1 was released reverting the changes. It now builds for me, but the vendor.css comes empty if I use this addon.

- This fixes a problem with non ascii files being corrupted (fonts in our case) - Removed ember-component-css addon as it was causing the vendor.css file to be empty see webark/ember-component-css#121

shillbom · 2016-03-02T07:33:50Z

@holandes22 Do you get the same issue if you run with sass? I could never get the plugin to work without it.

I guess there would be no problem updating to 2.4.1? We are aiming for the LTS release as soon as we can get it?

Sorry if this is the wrong place to discuss this!

holandes22 · 2016-03-02T07:40:00Z

@killbom yes, happens with sass. I never tried it with less or plain css actually

My two cents: I think targeting the 2.4 LTS is the right approach as that is exactly the intention of LTS releases.

Just a heads up, ember-cli 2.4.1 throws a deprecation warning when using vendorStaticStyles as it is deprecated API

cibernox · 2016-03-02T20:21:23Z

@webark I migrated from this to ember-css-modules yesterday. I won't say it is a perfect solution, but I do like the approach and I find it more flexible than css components.

ebryn · 2016-03-02T21:02:35Z

I just tested the addon in Ember-CLI 2.4.1 and it seems to work fine. Looking into #114.

timgthomas · 2016-03-02T21:06:24Z

@ebryn The build error is fixed with 2.4.1, true, but as @holandes22 mentioned, the vendor.css is now empty.

ebryn · 2016-03-02T22:27:00Z

I'm not seeing vendor.css being empty on my end, appears to be working
fine...

On Wed, Mar 2, 2016 at 1:06 PM, Tim G. Thomas [email protected]
wrote:

@ebryn https://github.com/ebryn The build error is fixed with 2.4.1,
true, but as @holandes22 https://github.com/holandes22 mentioned, the
vendor.css is now empty.

—
Reply to this email directly or view it on GitHub
#121 (comment)
.

webark · 2016-03-03T22:28:02Z

I"m seeing vendor.css being empty on my end.. are you using a pre complier..?

ebryn · 2016-03-04T19:40:18Z

No, I'm not using a preprocessor. Are you?

webark · 2016-03-04T20:49:36Z

ya

t4t5 · 2016-03-08T14:06:02Z

I have files missing in my vendor.css as well. Not sure what's causing it though. I'm using the Stylus preprocessor btw (if that has anything to do with it).

The odd thing is that the CSS files from this project are added to vendor.css with no problem, but the ones from this addon are completely omitted after the update to Ember CLI 2.4.1. :/

Before the update: (Both the ivy-codemirror and ember-blur-up css is imported)

After the update: (Only the ember-blur-up css is imported)

t4t5 · 2016-03-08T14:08:40Z

It also omits CSS that is imported directly through the ember-cli-build.js-file.

app.import('bower_components/sweetalert/dist/sweetalert.css');

...never shows up in vendor.css for example.

ankushdharkar · 2016-03-09T01:33:17Z

+1

I am facing the same problem as @t4t5

May have something to do with these changes in 2.4.0: ember-cli/ember-cli#5545

I am using an ember-cli-sass preprocessor. This is the error I get on running ember server:

version: 2.4.0
this.vendorStaticStyles.concat is not a function
TypeError: this.vendorStaticStyles.concat is not a function
    at EmberApp.styles (<Project-Destination>/node_modules/ember-component-css/index.js:85:43)
    at EmberApp.toArray (<Project-Destination>/node_modules/ember-cli/lib/broccoli/ember-app.js:1493:10)
    at EmberApp.toTree (<Project-Destination>/node_modules/ember-cli/lib/broccoli/ember-app.js:1514:30)
    at module.exports (<Project-Destination>/ember-cli-build.js:144:14)
    at Class.module.exports.Task.extend.setupBroccoliBuilder (<Project-Destination>/node_modules/ember-cli/lib/models/builder.js:55:19)
    at Class.module.exports.Task.extend.init (<Project-Destination>/node_modules/ember-cli/lib/models/builder.js:89:10)
    at new Class (<Project-Destination>/node_modules/core-object/core-object.js:18:12)
    at Class.module.exports.Task.extend.run (<Project-Destination>/node_modules/ember-cli/lib/tasks/serve.js:15:19)
    at <Project-Destination>/node_modules/ember-cli/lib/commands/serve.js:70:22
    at lib$rsvp$$internal$$tryCatch (<Project-Destination>/node_modules/rsvp/dist/rsvp.js:493:16)

backspace · 2016-03-09T13:30:00Z

@ankushdharkar, what if you try Ember CLI 2.4.1?

ankushdharkar · 2016-03-09T17:16:06Z

@backspace : That breaks too

backspace · 2016-03-09T19:14:40Z

Hmm, strange, that fixed it for me with ember-cli-sass.

ankushdharkar · 2016-03-10T03:51:58Z

@backspace: Just tried it again. It didn't work.

ebryn · 2016-03-22T05:16:49Z

Please give our newly released 0.2.0-beta.1 release a shot and let us know if that solves this issue for you.

ankushdharkar · 2016-03-22T18:19:42Z

@ebryn: 0.2.0-beta.1 is working. Thank you!

barneycarroll · 2016-06-23T13:45:22Z

Hello, just upgraded the Ember core toolchain to 2.4(.3), and vendor.css started coming out empty as others mentioned. Like many others, I'm using ember-cli-sass (5.3.1)

Upgrading ember-component-sass to 0.2.0 betas 1, 2, 3, 4, 5 and 6 reinstates vendor.css output but results in generated components no longer producing classNames corresponding with the generated styles.

@holandes22 did you manage to get your 2.4 SASS + pod styles working? Did it require any manual configuration changes?

webark · 2016-06-23T14:47:19Z

@barneycarroll did you try upgrading to the latest beta version?

barneycarroll · 2016-06-23T14:52:06Z

@webark yeah, no luck. The reason for this is due to my app having a slightly unorthodox pod file system hierarchy, in combination with brittle logic matching classNames at build and run time. Proposed a fork #151.

holandes22 mentioned this issue Mar 1, 2016

app.legacyFilesToAppend.push is not a function ember-cli/ember-cli#5537

Closed

backspace added a commit to backspace/ember-component-css that referenced this issue Mar 1, 2016

Update for Ember CLI 2.4.0

88eeeed

webark#121

ebryn closed this as completed Mar 2, 2016

This was referenced Mar 8, 2016

ember-cli-build.js is not importing any css file ember-cli/ember-cli#5422

Closed

External CSS isn't imported correctly #122

Closed

webark mentioned this issue Mar 9, 2016

Updated to maintain roughly the same api, but remove monkeypatches #123

Closed

barneycarroll mentioned this issue Jun 23, 2016

Correctly match runtime classnames to path-derived component names #151

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Broken with latest ember-cli (2.4.0) #121

Broken with latest ember-cli (2.4.0) #121

holandes22 commented Mar 1, 2016

nanuxbe commented Mar 1, 2016

Exelord commented Mar 1, 2016

shillbom commented Mar 1, 2016

cesarizu commented Mar 1, 2016

webark commented Mar 1, 2016

holandes22 commented Mar 2, 2016

shillbom commented Mar 2, 2016

holandes22 commented Mar 2, 2016

cibernox commented Mar 2, 2016

ebryn commented Mar 2, 2016

timgthomas commented Mar 2, 2016

ebryn commented Mar 2, 2016

webark commented Mar 3, 2016

ebryn commented Mar 4, 2016

webark commented Mar 4, 2016

t4t5 commented Mar 8, 2016

t4t5 commented Mar 8, 2016

ankushdharkar commented Mar 9, 2016

backspace commented Mar 9, 2016

ankushdharkar commented Mar 9, 2016

backspace commented Mar 9, 2016

ankushdharkar commented Mar 10, 2016

ebryn commented Mar 22, 2016

ankushdharkar commented Mar 22, 2016

barneycarroll commented Jun 23, 2016 •

edited

Loading

webark commented Jun 23, 2016

barneycarroll commented Jun 23, 2016

Broken with latest ember-cli (2.4.0) #121

Broken with latest ember-cli (2.4.0) #121

Comments

holandes22 commented Mar 1, 2016

nanuxbe commented Mar 1, 2016

Exelord commented Mar 1, 2016

shillbom commented Mar 1, 2016

cesarizu commented Mar 1, 2016

webark commented Mar 1, 2016

holandes22 commented Mar 2, 2016

shillbom commented Mar 2, 2016

holandes22 commented Mar 2, 2016

cibernox commented Mar 2, 2016

ebryn commented Mar 2, 2016

timgthomas commented Mar 2, 2016

ebryn commented Mar 2, 2016

webark commented Mar 3, 2016

ebryn commented Mar 4, 2016

webark commented Mar 4, 2016

t4t5 commented Mar 8, 2016

t4t5 commented Mar 8, 2016

ankushdharkar commented Mar 9, 2016

backspace commented Mar 9, 2016

ankushdharkar commented Mar 9, 2016

backspace commented Mar 9, 2016

ankushdharkar commented Mar 10, 2016

ebryn commented Mar 22, 2016

ankushdharkar commented Mar 22, 2016

barneycarroll commented Jun 23, 2016 • edited Loading

webark commented Jun 23, 2016

barneycarroll commented Jun 23, 2016

barneycarroll commented Jun 23, 2016 •

edited

Loading