Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Node 0.12.7 to be compatible with postcss changes #978

Closed
miketaylr opened this issue Mar 23, 2016 · 4 comments
Closed

Use Node 0.12.7 to be compatible with postcss changes #978

miketaylr opened this issue Mar 23, 2016 · 4 comments

Comments

@miketaylr
Copy link
Member

Travis is busted and I'm not 100% sure why.

https://travis-ci.org/webcompat/webcompat.com/builds/118036930

It works locally for me, but I don't want to leave master in a broken state until we understand it. So let's back it out.
@miketaylr
Copy link
Member Author 

Loading "cssnext.js" tasks...ERROR

>> ReferenceError: Promise is not defined

I see webpack-contrib/css-loader#144 (comment).

I'm on a super old Node (v0.12.7), maybe we need to upgrade and standardize on something more modern (v 4 or 5)

cc @magsout

@miketaylr
Copy link
Member Author

Hmm, webpack-contrib/css-loader#145 suggests that v0.12.7 should be OK. Maybe the problem is that Travis is using an even older version. Let me test something..

miketaylr pushed a commit that referenced this issue Mar 23, 2016
Issue #978. See if we can teach Travis to use Node 0.12.7
71573db
@miketaylr
Copy link
Member Author

OK, "Build #1555 passed."

Phew. 🔥 🚒 💧

@miketaylr miketaylr changed the title Back out postcss changes Use Node 0.12.7 to be compatible with postcss changes Mar 23, 2016
@miketaylr
Copy link
Member Author

(FWIW, I think Travis uses Node 0.8 if you don't specify a newer version).

daliacoss pushed a commit to daliacoss/webcompat.com that referenced this issue Mar 29, 2016
@daliacoss
Issue webcompat#978. See if we can teach Travis to use Node 0.12.7
bea2c03
@miketaylr miketaylr mentioned this issue Sep 7, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miketaylr