Bump stylelint-order from 4.1.0 to 6.0.3 #3757
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [stylelint-order](https://github.com/hudochenkov/stylelint-order) from 4.1.0 to 6.0.3. - [Release notes](https://github.com/hudochenkov/stylelint-order/releases) - [Changelog](https://github.com/hudochenkov/stylelint-order/blob/master/CHANGELOG.md) - [Commits](hudochenkov/stylelint-order@4.1.0...6.0.3) --- updated-dependencies: - dependency-name: stylelint-order dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
|
Yikes, this is a huge jump. But tests pass? WDYT @ksy36? |
|
It required Will need to migrate
|
|
Filed #3765 for updating styleint |
| @@ -18,6 +18,8 @@ | |||
| "selector-attribute-operator-space-before": "always", | |||
| "selector-attribute-operator-space-after": "always", | |||
| "selector-attribute-brackets-space-inside": "never", | |||
| "selector-class-pattern": null, | |||
| "selector-id-pattern": null, | |||
There was a problem hiding this comment.
Some of classnames/ids we're using don't pass the "kebab-case", which is the standard config now:
.SearchIssue-filter
.popup-modal.is--visible
.popup-modal__close
#js-ReportForm
.js-Issue-comment-body
.label-editorLauncher
...
webcompat/static/css/src/filter.css
1:6 ✖ Expected class selector to be kebab-case selector-class-pattern
webcompat/static/css/src/issue-wizard-popup.css
58:13 ✖ Expected class selector to be kebab-case selector-class-pattern
63:1 ✖ Expected class selector to be kebab-case selector-class-pattern
webcompat/static/css/src/issue-wizard.css
23:1 ✖ Expected id selector to be kebab-case selector-id-pattern
28:1 ✖ Expected id selector to be kebab-case selector-id-pattern
833:3 ✖ Expected id selector to be kebab-case selector-id-pattern
906:3 ✖ Expected id selector to be kebab-case selector-id-pattern
911:3 ✖ Expected id selector to be kebab-case selector-id-pattern
webcompat/static/css/src/issue.css
106:1 ✖ Expected class selector to be kebab-case selector-class-pattern
155:1 ✖ Expected class selector to be kebab-case selector-class-pattern
159:1 ✖ Expected class selector to be kebab-case selector-class-pattern
webcompat/static/css/src/label-editor.css
116:1 ✖ Expected class selector to be kebab-case selector-class-pattern
127:1 ✖ Expected class selector to be kebab-case selector-class-pattern
128:1 ✖ Expected class selector to be kebab-case selector-class-pattern
149:1 ✖ Expected class selector to be kebab-case selector-class-pattern
149:33 ✖ Expected class selector to be kebab-case selector-class-pattern
16 problems (16 errors, 0 warnings)
I've disabled it for now, but it probably should be addressed to have a unified naming convention.
|
r? @miketaylr |
|
Thanks! |
Bumps stylelint-order from 4.1.0 to 6.0.3.
Release notes
Sourced from stylelint-order's releases.
Changelog
Sourced from stylelint-order's changelog.
Commits
7bf79756.0.3d8a6ad8Prepare 6.0.37355fa5Fix sorting inside CSS-in-JScsshelper56d520f6.0.215419e1Prepare 6.0.23462a22Update dependencies9c28b80Add Stylelint 15 support (#171)bfcf8016.0.1b12cc6dPrepare 6.0.187ad51aFix regression causing root of CSS or SCSS to report violations. Fixes #167You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)