Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Vue to the version which will hit 100% #2074

Merged
merged 2 commits into from
May 4, 2023

Conversation

edimitchel
Copy link
Contributor

As for now, Vue hit a 91% of compatibility. 9% missing is (was) about capitalized events which Vue wasn't able to listen using the directive v-on or @.

Since the version 3.2.38, this is now more the case and Capitalized event is supported.

This PR is making the version update, put the minor version to 2, and as minimal patch version to the 38. But for sure, the latest patch version is installed.

@google-cla
Copy link

google-cla bot commented Mar 2, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@edimitchel edimitchel changed the title fix: update vue to the version which hit 100% fix: update vue to the version which will hit 100% Mar 2, 2023
@edimitchel edimitchel changed the title fix: update vue to the version which will hit 100% fix: update Vue to the version which will hit 100% Mar 3, 2023
@SoCuul
Copy link

SoCuul commented Apr 12, 2023

Bump

Copy link
Collaborator

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This LGTM.

@AndrewJakubowicz
Copy link
Collaborator

@rictic Am I able to trigger the actions to get this merged? Thank you!

@rictic rictic force-pushed the fix/update-vue-version branch from cefaf5c to a488026 Compare May 4, 2023 18:34
@rictic rictic enabled auto-merge (squash) May 4, 2023 18:36
@rictic rictic disabled auto-merge May 4, 2023 18:36
@rictic rictic enabled auto-merge (squash) May 4, 2023 18:36
@rictic rictic force-pushed the fix/update-vue-version branch from a488026 to 30f0759 Compare May 4, 2023 19:09
@rictic rictic merged commit 30f0759 into webcomponents:main May 4, 2023
@AndrewJakubowicz
Copy link
Collaborator

Thank you!

@rictic
Copy link
Contributor

rictic commented May 4, 2023

Thank you for catching this!

@edimitchel edimitchel deleted the fix/update-vue-version branch May 4, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants