-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update Vue to the version which will hit 100% #2074
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This LGTM.
@rictic Am I able to trigger the actions to get this merged? Thank you! |
cefaf5c
to
a488026
Compare
a488026
to
30f0759
Compare
Thank you! |
Thank you for catching this! |
As for now, Vue hit a 91% of compatibility. 9% missing is (was) about capitalized events which Vue wasn't able to listen using the directive
v-on
or@
.Since the version 3.2.38, this is now more the case and Capitalized event is supported.
This PR is making the version update, put the minor version to 2, and as minimal patch version to the 38. But for sure, the latest patch version is installed.