-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated README with Swift Package support instructions. #74
Updated README with Swift Package support instructions. #74
Conversation
README.md
Outdated
* The important part to note is the use of `-scmProvider system` as it specifies SPM to use the current system's git configuration and **NOT** Xcode's. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Puh, it's really hard for me (as I have never used Swift) to judge this section.
My expectation was that this last line (add -scmProvider system
to xcodebuild
?) is all you need to know to make this action work.
I mean, isn't the rest about how to set up a private repo in the first place, something people already have when they use this action?
Also, this is only necessary when dealing with multiple deploy keys, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have moved and consolidated a bit. However, I personally feel like its helpful to have all the steps listed in one spot. It is not always clear what steps are all required, which is why it took 3 various articles (this documentation + an example in another issue + a StackOverflow post) before I was able to correctly get this working.
By listing here in one spot, future devs can hopefully save time on getting up and running.
Please feel free to update and commit directly to this branch though if you have a personal preference.
@cerupcat I know you're using Swift with private dependenies as well. Could you help us to review this additional information for Swift users? |
I plan to go through the Readme within the next couple of days and try the steps myself to confirm the same thing works for me. |
@rr-james-hickman Thank you James for being so persistent on this one! As I've mentioned above, I felt like the details you gave in the README for Swift were more than necessary. I was afraid of making the README hard to digest, and also afraid of having too much information in it that might get out of date and was not exactly on scope for this action. I did, however, pick two small additions and just committed them on What do you think – does that do it for you? Thank you again for your energy put into this! |
@mpdude No worries, glad to be of service. Hopefully future devs can avoid the headaches I had when trying to get everything to work properly in this type of environment setup. |
Added instructions per request in #73