require.js does not use application.context property #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @huntc |
|
Sounds like we should enhance the plugin to consider this property also. I'll try and get to this next week if you'd like. |
|
@ArtemKozlov @jamesward Can you please review my PR? @jamesward Please merge and deploy as appropriate. |
|
@huntc LGTM |
jamesward
added a commit
that referenced
this pull request
May 27, 2013
require.js does not use application.context property
|
This is released as |
|
It still seems to be missing a final "/". Do you have example of this working? |
|
@jackchi Can you file another issue for that? |
|
@jamesward done! #32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated require.js dependencies script ignores application.context property.
For example I have some -Dapplication.context=/my-context, but in generated require.js dependencies fullPath is without context. For example:
fullPath: "/webjars/requirejs/2.1.5/require.js"
but it should be:
fullPath: "/my-context/webjars/requirejs/2.1.5/require.js"