Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add semester status filtering in BDB #5323

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add semester status filtering in BDB #5323

wants to merge 7 commits into from

Conversation

Bestem0r
Copy link
Contributor

@Bestem0r Bestem0r commented Feb 3, 2025 •
edited
Loading

Description

Adds inline filtering to semester statuses in BDB Pro. Choosing multiple filters works as or on the semester statuses.

Backend PR

Result

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.
Screencast.From.2025-02-03.17-38-01.mp4

Testing

  • I have thoroughly tested my changes.

Resolves ABA-1048

@Bestem0r Bestem0r added review-needed Pull requests that need review new-feature Pull requests that introduce a new feature labels Feb 3, 2025
@Bestem0r Bestem0r requested a review from ivarnakken February 3, 2025 16:51
@linear Linear
Copy link

linear bot commented Feb 3, 2025

ABA-1048 Improve BDB

ABA-1215 Add filtering and sorting options to BDB

@vercel Vercel
Copy link

vercel bot commented Feb 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2025 8:57pm

@Bestem0r Bestem0r mentioned this pull request Feb 3, 2025
Open
4 tasks
ch0rizo
ch0rizo reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@ch0rizo ch0rizo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, very nice

@Bestem0r Bestem0r requested review from eikhr and falbru February 4, 2025 19:29
emillub
emillub approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@emillub emillub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

norbye
norbye requested changes Feb 5, 2025
View reviewed changes
Copy link
Member

@norbye norbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slapping on a small changes requested - just cause I want to hear about the path stuff to ensure that we're not leaving unnecessary invalid paths in our wake.

Otherwise it looks very nice

@Bestem0r Bestem0r requested a review from norbye February 6, 2025 16:03
norbye
norbye requested changes Feb 6, 2025
View reviewed changes
app/routes/bdb/components/BdbDetail.tsx Outdated Show resolved Hide resolved
app/routes/bdb/components/CompanyEditor.tsx Outdated Show resolved Hide resolved
app/routes/company/components/CompaniesPage.tsx Outdated Show resolved Hide resolved
@Bestem0r Bestem0r requested a review from norbye February 6, 2025 20:57
norbye
norbye approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@norbye norbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

ivarnakken
ivarnakken approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch0rizo ch0rizo ch0rizo left review comments

@norbye norbye norbye approved these changes

@ivarnakken ivarnakken ivarnakken approved these changes

@emillub emillub emillub approved these changes

@eikhr eikhr Awaiting requested review from eikhr

@falbru falbru Awaiting requested review from falbru

Assignees
No one assigned
Labels
new-feature Pull requests that introduce a new feature review-needed Pull requests that need review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Bestem0r @norbye @ivarnakken @ch0rizo @emillub