Ensure unaliasedPath does not grow for each list item

webonyx · Jun 19, 2024 · 4ddba16 · 4ddba16
1 parent a525e5b
commit 4ddba16
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,12 @@ You can find and compare releases at the [GitHub release page](https://github.co
 
 ## Unreleased
 
+## v15.12.4
+
+### Fixed
+
+- Ensure unaliasedPath does not grow for each list item https://github.com/webonyx/graphql-php/pull/1579
+
 ## v15.12.3
 
 ### Fixed

diff --git a/src/Executor/ReferenceExecutor.php b/src/Executor/ReferenceExecutor.php
@@ -1012,13 +1012,13 @@ protected function completeListValue(
         $containsPromise = false;
         $completedItems = [];
         foreach ($results as $item) {
-            $fieldPath = [...$path, $i];
-            $info->path = $fieldPath;
-            $unaliasedPath = [...$unaliasedPath, $i];
-            $info->unaliasedPath = $unaliasedPath;
+            $itemPath = [...$path, $i];
+            $info->path = $itemPath;
+            $itemUnaliasedPath = [...$unaliasedPath, $i];
+            $info->unaliasedPath = $itemUnaliasedPath;
             ++$i;
 
-            $completedItem = $this->completeValueCatchingError($itemType, $fieldNodes, $info, $fieldPath, $unaliasedPath, $item, $contextValue);
+            $completedItem = $this->completeValueCatchingError($itemType, $fieldNodes, $info, $itemPath, $itemUnaliasedPath, $item, $contextValue);
 
             if (! $containsPromise && $this->getPromise($completedItem) !== null) {
                 $containsPromise = true;